From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C1FC3A5A9 for ; Mon, 4 May 2020 10:20:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2205E206E6 for ; Mon, 4 May 2020 10:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i4LIp5MJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2205E206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVYCx-0000yQ-7x for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 06:20:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVYCK-0000Xm-TL for qemu-devel@nongnu.org; Mon, 04 May 2020 06:19:40 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47318 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVYCK-0001fn-3b for qemu-devel@nongnu.org; Mon, 04 May 2020 06:19:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588587579; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfmnRLjHMZPruqAUKbzhEiqZID/6kyZVYXfhOdAkLNE=; b=i4LIp5MJL8FP04tBK/ng2p91CjoTdU4hevyblRyqY8qy6Qxmy6OJe8Suid+MN6UwBMkfnV /KEv74XBBtaIk2qF8VzaO0QlBHRlVX7C8Q9k8Xv++QdQq2uFxG8AZ7M64olTeUEJ2rOPwe 0AzbpzSMBhTj9uyVEC/jhsyjRljRvXo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-U5FEqviNPqWUtX2jd7IAnw-1; Mon, 04 May 2020 06:19:35 -0400 X-MC-Unique: U5FEqviNPqWUtX2jd7IAnw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9314100CCC3; Mon, 4 May 2020 10:19:34 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C580819C58; Mon, 4 May 2020 10:19:28 +0000 (UTC) Date: Mon, 4 May 2020 11:19:25 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Maxim Levitsky Subject: Re: [PATCH v3 00/14] LUKS: encryption slot management using amend interface Message-ID: <20200504101925.GH115875@redhat.com> References: <20200503184324.12506-1-mlevitsk@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200503184324.12506-1-mlevitsk@redhat.com> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 04:24:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, May 03, 2020 at 09:43:10PM +0300, Maxim Levitsky wrote: > Hi! > Here is the updated series of my patches, incorporating all the feedback = I received. >=20 > This implements the API interface that we agreed upon except that I merge= d the > LUKSKeyslotActive/LUKSKeyslotInactive union into a struct because otherwi= se > I need nested unions which are not supported currently by QAPI parser. > This didn't change the API and thus once support for nested unions is the= re, > it can always be implemented in backward compatible way. >=20 > I hope that this series will finally be considered for merging, since I a= m somewhat running > out of time to finish this task. >=20 > Patches are strictly divided by topic to 3 groups, and each group depends= on former groups. >=20 > * Patches 1,2 implement qcrypto generic amend interface, including defini= tion > of structs used in crypto.json and implement this in luks crypto driver > Nothing is exposed to the user at this stage >=20 > * Patches 3-9 use the code from patches 1,2 to implement qemu-img amend b= ased encryption slot management > for luks and for qcow2, and add a bunch of iotests to cover that. >=20 > * Patches 10-13 add x-blockdev-amend (I'll drop the -x prefix if you like= ), and wire it > to luks and qcow2 driver to implement qmp based encryption slot managem= ent also using > the code from patches 1,2, and also add a bunch of iotests to cover thi= s. >=20 > Tested with -raw,-qcow2 and -luks iotests and 'make check' >=20 > V3: rebased, addressed most of the review feedback. > For now I kept the slot bitmap code since I am not sure that replacing it= will be better. I'm still of the opinion that the bitmaps code should be replaced. With this current design we are iterating over the slot of keys slots 4 times, doing different checks/logic in each iteration. This is really not nice for understanding how the code works. IMHO we should be iterating at most twice - once to validate the requested configuration, and once to apply the requested configuration. Even if there si duplication of logic in between the delete/add key codepaths, I think it will be better as the logic for each operation will be in one place. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|