From: Cornelia Huck <cohuck@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct()
Date: Mon, 4 May 2020 17:29:38 +0200 [thread overview]
Message-ID: <20200504172938.00fba6de.cohuck@redhat.com> (raw)
In-Reply-To: <87pnbjzpro.fsf@dusky.pond.sub.org>
On Mon, 04 May 2020 17:24:59 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Cornelia Huck <cohuck@redhat.com> writes:
>
> > On Wed, 29 Apr 2020 07:51:04 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> David Hildenbrand <david@redhat.com> writes:
> >>
> >> > On 24.04.20 21:20, Markus Armbruster wrote:
> >> >> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API
> >> >> violations" neglected to change visit_end_struct()'s Error ** argument
> >> >> along with the others. If visit_end_struct() failed, we'd take the
> >> >
> >> > s/visit_end_struct/visit_check_struct/ ?
> >>
> >> Will fix.
> >>
> >> >> success path. Fortunately, it can't fail here:
> >> >> qobject_input_check_struct() checks we consumed the whole dictionary,
> >> >> and to get here, we did. Fix it anyway.
> >> >
> >> > AFAIKs, if visit_check_struct() failed, we'd still do the memcopy, but
> >> > also report the error. Not nice, not bad.
> >> >
> >> > Reviewed-by: David Hildenbrand <david@redhat.com>
> >>
> >> Thanks!
> >
> > Will you queue this, or shall I queue it?
>
> Me taking the complete series through my tree would be easiest for me.
> But I can cope with other maintainers picking up bits.
In that case, have my
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
and feel free to pick up :)
next prev parent reply other threads:[~2020-05-04 15:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 19:20 [PATCH 00/11] More miscellaneous error handling fixes Markus Armbruster
2020-04-24 19:20 ` [PATCH 01/11] nvdimm: Plug memory leak in uuid property setter Markus Armbruster
2020-04-24 19:20 ` [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors Markus Armbruster
2020-04-27 7:26 ` Paul Durrant
2020-04-29 5:48 ` Markus Armbruster
2020-04-24 19:20 ` [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct() Markus Armbruster
2020-04-27 8:02 ` David Hildenbrand
2020-04-29 5:51 ` Markus Armbruster
2020-05-04 11:09 ` Cornelia Huck
2020-05-04 15:24 ` Markus Armbruster
2020-05-04 15:29 ` Cornelia Huck [this message]
2020-04-24 19:20 ` [PATCH 04/11] s390x/pci: Fix harmless mistake in zpci's property fid's setter Markus Armbruster
2020-04-27 14:11 ` Matthew Rosato
2020-04-27 14:40 ` Markus Armbruster
2020-04-24 19:20 ` [PATCH 05/11] tests/migration: Tighten error checking Markus Armbruster
2020-04-24 19:20 ` [PATCH 06/11] error: Use error_reportf_err() where appropriate Markus Armbruster
2020-04-24 20:08 ` Eric Blake
2020-04-27 8:53 ` Markus Armbruster
2020-04-27 9:26 ` Philippe Mathieu-Daudé
2020-04-27 13:59 ` Eric Blake
2020-04-24 19:20 ` [PATCH 07/11] mips/malta: Fix create_cps() error handling Markus Armbruster
2020-04-27 9:20 ` Philippe Mathieu-Daudé
2020-04-29 5:59 ` Markus Armbruster
2020-04-29 7:13 ` Philippe Mathieu-Daudé
2020-04-29 7:27 ` Markus Armbruster
2020-04-24 19:20 ` [PATCH 08/11] mips/boston: Fix boston_mach_init() " Markus Armbruster
2020-04-29 6:33 ` Markus Armbruster
2020-04-24 19:20 ` [PATCH 09/11] mips/boston: Plug memory leak in boston_mach_init() Markus Armbruster
2020-04-24 19:20 ` [PATCH 10/11] arm/sabrelite: Consistently use &error_fatal in sabrelite_init() Markus Armbruster
2020-04-27 9:17 ` Philippe Mathieu-Daudé
2020-04-24 19:20 ` [PATCH 11/11] i386: Fix x86_cpu_load_model() error API violation Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504172938.00fba6de.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).