From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B8E6C47254 for ; Tue, 5 May 2020 13:40:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60E282073B for ; Tue, 5 May 2020 13:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T5gupwwW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60E282073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVxnl-0004VQ-HR for qemu-devel@archiver.kernel.org; Tue, 05 May 2020 09:40:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVxmq-0003ZH-Po for qemu-devel@nongnu.org; Tue, 05 May 2020 09:39:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44236 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVxmp-0008Vk-Nw for qemu-devel@nongnu.org; Tue, 05 May 2020 09:39:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588685942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CpS2hNin1DzopWwXbcaleB8fl8r5pm7mv3//2vM4sI=; b=T5gupwwWLqMyCcngJecpukvTnLv2FOack4gp8gDayOU5XwYYmsLwvkwFSB6y18I5Ysps3I v1Nuqr4EAcmpblBYJ6La66f7I96x6MbdGt/C5/o8ULSfTbTV8GiZXOhXEbb+h9qI5nBlA5 xZVvn0UCOZyD/ZK/dUoCvliy1Z9tmcE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-bfkFOcsYOKmojUSlWa-xuQ-1; Tue, 05 May 2020 09:39:00 -0400 X-MC-Unique: bfkFOcsYOKmojUSlWa-xuQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0814106B259; Tue, 5 May 2020 13:38:59 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C7DF36295C; Tue, 5 May 2020 13:38:45 +0000 (UTC) Date: Tue, 5 May 2020 15:38:43 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt Message-ID: <20200505153843.51d49d9f@redhat.com> In-Reply-To: <20200505113843.22012-13-kraxel@redhat.com> References: <20200505113843.22012-1-kraxel@redhat.com> <20200505113843.22012-13-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 00:37:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 5 May 2020 13:38:42 +0200 Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 1922868f3401..765409a90eb6 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1437,15 +1437,6 @@ static void build_q35_isa_bridge(Aml *table) > aml_append(field, aml_named_field("LPTD", 2)); ^^^^ not related to this patch but it seems that above&co are also unused fields. it was this way in Seabios and probably even earlier wherever it was copied from. > aml_append(dev, field); > > - aml_append(dev, aml_operation_region("LPCE", AML_PCI_CONFIG, > - aml_int(0x82), 0x02)); > - /* enable bits */ > - field = aml_field("LPCE", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); > - aml_append(field, aml_named_field("CAEN", 1)); > - aml_append(field, aml_named_field("CBEN", 1)); > - aml_append(field, aml_named_field("LPEN", 1)); > - aml_append(dev, field); > - > aml_append(scope, dev); > aml_append(table, scope); > } > @@ -1469,7 +1460,6 @@ static void build_piix4_isa_bridge(Aml *table) > { > Aml *dev; > Aml *scope; > - Aml *field; > > scope = aml_scope("_SB.PCI0"); > dev = aml_device("ISA"); > @@ -1478,19 +1468,6 @@ static void build_piix4_isa_bridge(Aml *table) > /* PIIX PCI to ISA irq remapping */ > aml_append(dev, aml_operation_region("P40C", AML_PCI_CONFIG, > aml_int(0x60), 0x04)); > - /* enable bits */ > - field = aml_field("^PX13.P13C", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE); ^^^ should we drop this as well as it becomes unused? > - /* Offset(0x5f),, 7, */ > - aml_append(field, aml_reserved_field(0x2f8)); > - aml_append(field, aml_reserved_field(7)); > - aml_append(field, aml_named_field("LPEN", 1)); > - /* Offset(0x67),, 3, */ > - aml_append(field, aml_reserved_field(0x38)); > - aml_append(field, aml_reserved_field(3)); > - aml_append(field, aml_named_field("CAEN", 1)); > - aml_append(field, aml_reserved_field(3)); > - aml_append(field, aml_named_field("CBEN", 1)); > - aml_append(dev, field); > > aml_append(scope, dev); > aml_append(table, scope);