qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, gshan@redhat.com,
	shannon.zhaosl@gmail.com, qemu-devel@nongnu.org,
	Eric Auger <eric.auger@redhat.com>,
	qemu-arm@nongnu.org, marcandre.lureau@redhat.com,
	imammedo@redhat.com, eric.auger.pro@gmail.com, lersek@redhat.com,
	ardb@kernel.org, stefanb@linux.ibm.com
Subject: Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part
Date: Wed, 6 May 2020 05:58:25 -0400	[thread overview]
Message-ID: <20200506055747-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200506063314.4qvnyfonjixcknuj@kamzik.brq.redhat.com>

On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote:
> I realize this function is just getting moved, but maybe it should get
> converted to the build_append* API while being moved?

I'd rather refactoring was done in a separate patch -
easier to review.

-- 
MST



  parent reply	other threads:[~2020-05-06  9:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 14:44 [PATCH v2 0/3] vTPM/aarch64 ACPI support Eric Auger
2020-05-05 14:44 ` [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part Eric Auger
2020-05-05 16:17   ` Stefan Berger
2020-05-06  6:33   ` Andrew Jones
2020-05-06  9:50     ` Auger Eric
2020-05-12 14:10       ` Igor Mammedov
2020-05-12 14:56         ` Auger Eric
2020-05-06  9:58     ` Michael S. Tsirkin [this message]
2020-05-12 14:14       ` Igor Mammedov
2020-05-12 15:59         ` Auger Eric
2020-05-14  9:53           ` Igor Mammedov
2020-05-05 14:44 ` [PATCH v2 2/3] arm/acpi: TPM2 ACPI table support Eric Auger
2020-05-05 16:16   ` Stefan Berger
2020-05-12 14:27   ` Igor Mammedov
2020-05-12 16:06     ` Auger Eric
2020-05-05 14:44 ` [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT Eric Auger
2020-05-08 15:24   ` Shannon Zhao
2020-05-08 15:25     ` Ard Biesheuvel
2020-05-08 19:15       ` Stefan Berger
2020-05-12 14:57   ` Igor Mammedov
2020-05-05 16:19 ` [PATCH v2 0/3] vTPM/aarch64 ACPI support Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506055747-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ardb@kernel.org \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=gshan@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).