From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
stefanha@redhat.com, codyprime@gmail.com, sw@weilnetz.de,
pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com,
ronniesahlberg@gmail.com, den@openvz.org, pbonzini@redhat.com
Subject: [PATCH 1/8] block/vdi: return ZERO block-status when appropriate
Date: Wed, 6 May 2020 12:25:06 +0300 [thread overview]
Message-ID: <20200506092513.20904-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200506092513.20904-1-vsementsov@virtuozzo.com>
In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk
of qiov. So, this should be reported as ZERO.
After block-status update, it never reports 0, so setting
unallocated_blocks_are_zero doesn't make sense. Drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block/vdi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 0c7835ae70..83471528d2 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -334,7 +334,6 @@ static int vdi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
logout("\n");
bdi->cluster_size = s->block_size;
bdi->vm_state_offset = 0;
- bdi->unallocated_blocks_are_zero = true;
return 0;
}
@@ -536,7 +535,7 @@ static int coroutine_fn vdi_co_block_status(BlockDriverState *bs,
*pnum = MIN(s->block_size - index_in_block, bytes);
result = VDI_IS_ALLOCATED(bmap_entry);
if (!result) {
- return 0;
+ return BDRV_BLOCK_ZERO;
}
*map = s->header.offset_data + (uint64_t)bmap_entry * s->block_size +
--
2.21.0
next prev parent reply other threads:[~2020-05-06 9:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:25 [PATCH 0/8] drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` Vladimir Sementsov-Ogievskiy [this message]
2020-05-06 13:57 ` [PATCH 1/8] block/vdi: return ZERO block-status when appropriate Eric Blake
2020-05-06 14:49 ` Vladimir Sementsov-Ogievskiy
2020-05-07 7:22 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 2/8] block/vpc: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:18 ` Eric Blake
2020-05-07 7:08 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 3/8] block/crypto: drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 21:21 ` Eric Blake
2020-05-06 9:25 ` [PATCH 4/8] block/iscsi: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:25 ` Eric Blake
2020-05-06 9:25 ` [PATCH 5/8] block/file-posix: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:41 ` Eric Blake
2020-05-06 9:25 ` [PATCH 6/8] block/vhdx: " Vladimir Sementsov-Ogievskiy
2020-05-06 21:43 ` Eric Blake
2020-05-06 9:25 ` [PATCH 7/8] qemu-img: convert: don't use unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 14:49 ` Eric Blake
2020-05-06 14:58 ` Vladimir Sementsov-Ogievskiy
2020-05-06 9:25 ` [PATCH 8/8] block: drop unallocated_blocks_are_zero Vladimir Sementsov-Ogievskiy
2020-05-06 15:14 ` Eric Blake
2020-05-06 15:30 ` Vladimir Sementsov-Ogievskiy
2020-05-07 7:05 ` Vladimir Sementsov-Ogievskiy
2020-05-07 8:24 ` Vladimir Sementsov-Ogievskiy
2020-05-07 8:35 ` Vladimir Sementsov-Ogievskiy
2020-05-06 15:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506092513.20904-2-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=codyprime@gmail.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).