From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org
Subject: [PULL 09/14] tests/tcg: drop inferior.was_attached() test
Date: Wed, 6 May 2020 13:05:24 +0100 [thread overview]
Message-ID: <20200506120529.18974-10-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200506120529.18974-1-alex.bennee@linaro.org>
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200430190122.4592-5-alex.bennee@linaro.org>
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 387b2fc20aa..972cf73c315 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py b/tests/tcg/aarch64/gdbstub/test-sve.py
index 5995689625e..b96bdbb99af 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
next prev parent reply other threads:[~2020-05-06 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 12:05 [PULL 00/14] testing and gdbstub updates Alex Bennée
2020-05-06 12:05 ` [PULL 01/14] .travis.yml: show free disk space at end of run Alex Bennée
2020-05-06 12:05 ` [PULL 02/14] .travis.yml: drop MacOSX Alex Bennée
2020-05-06 12:05 ` [PULL 03/14] .cirrus.yml: bump FreeBSD to the current stable release Alex Bennée
2020-05-06 12:05 ` [PULL 04/14] .cirrus.yml: bootstrap pkg unconditionally Alex Bennée
2020-05-06 12:05 ` [PULL 05/14] .travis.yml: reduce the load on [ppc64] GCC check-tcg Alex Bennée
2020-05-06 12:05 ` [PULL 06/14] configure: favour gdb-multiarch if we have it Alex Bennée
2020-05-06 12:05 ` [PULL 07/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Alex Bennée
2020-05-06 12:05 ` [PULL 08/14] tests/tcg: better trap gdb failures Alex Bennée
2020-05-06 12:05 ` Alex Bennée [this message]
2020-05-06 12:05 ` [PULL 10/14] gdbstub: eliminate gdbserver_fd global Alex Bennée
2020-05-06 12:05 ` [PULL 11/14] gdbstub/linux-user: support debugging over a unix socket Alex Bennée
2020-05-06 12:05 ` [PULL 12/14] tests/guest-debug: use the unix socket for linux-user tests Alex Bennée
2020-05-06 12:05 ` [PULL 13/14] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-05-06 12:05 ` [PULL 14/14] target/m68k: fix gdb for m68xxx Alex Bennée
2020-05-06 14:37 ` [PULL 00/14] testing and gdbstub updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506120529.18974-10-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).