From: Eyal Moscovici <eyal.moscovici@oracle.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eyal Moscovici <eyal.moscovici@oracle.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
liran.alon@oracle.com
Subject: [PATCH v2 1/5] qemu-img: remove check that cvtnum value > MAX_INT
Date: Thu, 7 May 2020 00:34:55 +0300 [thread overview]
Message-ID: <20200506213459.44743-2-eyal.moscovici@oracle.com> (raw)
In-Reply-To: <20200506213459.44743-1-eyal.moscovici@oracle.com>
Following commit f46bfdbfc8f95cf65d7818ef68a801e063c40332 (util/cutils: Change
qemu_strtosz*() from int64_t to uint64_t) which added a similar check to
cvtnum. As a result there is no need to check it separately outside of cvtnum.
Acked-by: Mark Kanda <mark.kanda@oracle.com>
Signed-off-by: Eyal Moscovici <eyal.moscovici@oracle.com>
---
qemu-img.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 6a4327aaba..116a9c6349 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4307,7 +4307,7 @@ static int img_bench(int argc, char **argv)
int64_t sval;
sval = cvtnum(optarg);
- if (sval < 0 || sval > INT_MAX) {
+ if (sval < 0) {
error_report("Invalid buffer size specified");
return 1;
}
@@ -4320,7 +4320,7 @@ static int img_bench(int argc, char **argv)
int64_t sval;
sval = cvtnum(optarg);
- if (sval < 0 || sval > INT_MAX) {
+ if (sval < 0) {
error_report("Invalid step size specified");
return 1;
}
@@ -4493,7 +4493,7 @@ static int img_dd_bs(const char *arg,
res = cvtnum(arg);
- if (res <= 0 || res > INT_MAX) {
+ if (res <= 0) {
error_report("invalid number: '%s'", arg);
return 1;
}
--
2.17.2 (Apple Git-113)
next prev parent reply other threads:[~2020-05-06 21:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 9:11 [PATCH 0/2] Additional parameters for qemu_img map Eyal Moscovici
2020-03-22 9:11 ` [PATCH 1/2] qemu-img: refactor dump_map_entry JSON format output Eyal Moscovici
2020-04-29 14:58 ` Eric Blake
2020-05-06 9:55 ` Eyal Moscovici
2020-03-22 9:11 ` [PATCH 2/2] qemu-img: Add --start-offset and --max-length to map Eyal Moscovici
2020-04-29 15:04 ` Eric Blake
2020-05-06 9:52 ` Eyal Moscovici
2020-04-29 13:39 ` [PATCH 0/2] Additional parameters for qemu_img map John Snow
2020-05-06 21:34 ` [PATCH v2 0/5] " Eyal Moscovici
2020-05-06 21:34 ` Eyal Moscovici [this message]
2020-05-06 21:49 ` [PATCH v2 1/5] qemu-img: remove check that cvtnum value > MAX_INT Eric Blake
2020-05-12 9:39 ` Eyal Moscovici
2020-05-12 14:14 ` Eric Blake
2020-05-06 21:34 ` [PATCH v2 2/5] qemu_img: add error report to cvtnum Eyal Moscovici
2020-05-06 21:59 ` Eric Blake
2020-05-12 9:44 ` Eyal Moscovici
2020-05-06 21:34 ` [PATCH v2 3/5] qemu-img: validate image length in img_map Eyal Moscovici
2020-05-06 22:01 ` Eric Blake
2020-05-06 21:34 ` [PATCH v2 4/5] qemu-img: refactor dump_map_entry JSON format output Eyal Moscovici
2020-05-06 21:34 ` [PATCH v2 5/5] qemu-img: Add --start-offset and --max-length to map Eyal Moscovici
2020-05-06 22:04 ` Eric Blake
2020-05-12 9:48 ` Eyal Moscovici
2020-05-06 21:45 ` [PATCH v2 0/5] Additional parameters for qemu_img map Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506213459.44743-2-eyal.moscovici@oracle.com \
--to=eyal.moscovici@oracle.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).