From: Alexander Bulekov <alxndr@bu.edu>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, berrange@redhat.com,
stefanha@redhat.com, Alexander Bulekov <alxndr@bu.edu>
Subject: [PATCH v2 2/2] char-file: add test for distinct path= and pathin=
Date: Thu, 7 May 2020 02:24:42 -0400 [thread overview]
Message-ID: <20200507062442.15215-3-alxndr@bu.edu> (raw)
In-Reply-To: <20200507062442.15215-1-alxndr@bu.edu>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
tests/test-char.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 83 insertions(+)
diff --git a/tests/test-char.c b/tests/test-char.c
index 3afc9b1b8d..9b3e1e2a9b 100644
--- a/tests/test-char.c
+++ b/tests/test-char.c
@@ -1228,6 +1228,88 @@ static void char_file_test_internal(Chardev *ext_chr, const char *filepath)
g_free(out);
}
+static int file_can_read(void *opaque)
+{
+ return 4096;
+}
+
+static void file_read(void *opaque, const uint8_t *buf, int size)
+{
+ int ret;
+ Chardev *chr = *(Chardev **)opaque;
+ g_assert_cmpint(size, <=, file_can_read(opaque));
+
+ g_assert_cmpint(size, ==, 6);
+ g_assert(strncmp((const char *)buf, "hello!", 6) == 0);
+ ret = qemu_chr_write_all(chr, buf, size);
+ g_assert_cmpint(ret, ==, 6);
+ quit = true;
+}
+
+static void char_file_separate_input_file(void)
+{
+ char *tmp_path = g_dir_make_tmp("qemu-test-char.XXXXXX", NULL);
+ char *in;
+ char *out;
+ QemuOpts *opts;
+ Chardev *chr;
+ ChardevFile file = {};
+ CharBackend be;
+ ChardevBackend backend = { .type = CHARDEV_BACKEND_KIND_FILE,
+ .u.file.data = &file };
+ char *contents = NULL;
+ gsize length;
+ int ret;
+
+ in = g_build_filename(tmp_path, "in", NULL);
+ out = g_build_filename(tmp_path, "out", NULL);
+
+ ret = g_file_set_contents(in, "hello!", 6, NULL);
+
+ opts = qemu_opts_create(qemu_find_opts("chardev"), "serial-id",
+ 1, &error_abort);
+ qemu_opt_set(opts, "backend", "file", &error_abort);
+ qemu_opt_set(opts, "pathin", in, &error_abort);
+ qemu_opt_set(opts, "path", out, &error_abort);
+
+ chr = qemu_chr_new_from_opts(opts, NULL, NULL);
+ qemu_chr_fe_init(&be, chr, &error_abort);
+
+ file.has_in = true;
+ file.in = in;
+ file.out = out;
+
+
+ qemu_chr_fe_set_handlers(&be, file_can_read,
+ file_read,
+ NULL, NULL, &chr, NULL, true);
+
+ chr = qemu_chardev_new(NULL, TYPE_CHARDEV_FILE, &backend,
+ NULL, &error_abort);
+ main_loop(); /* should call file_read, and copy contents of in to out */
+
+ qemu_chr_fe_deinit(&be, true);
+
+ /* Check that contents of in were copied to out */
+ ret = g_file_get_contents(out, &contents, &length, NULL);
+ g_assert(ret == TRUE);
+ g_assert_cmpint(length, ==, 6);
+ g_assert(strncmp(contents, "hello!", 6) == 0);
+ g_free(contents);
+
+ /* Check that in hasn't changed */
+ ret = g_file_get_contents(in, &contents, &length, NULL);
+ g_assert(ret == TRUE);
+ g_assert_cmpint(length, ==, 6);
+ g_assert(strncmp(contents, "hello!", 6) == 0);
+
+ g_free(contents);
+ g_rmdir(tmp_path);
+ g_free(tmp_path);
+ g_free(in);
+ g_free(out);
+}
+
static void char_file_test(void)
{
char_file_test_internal(NULL, NULL);
@@ -1398,6 +1480,7 @@ int main(int argc, char **argv)
g_test_add_func("/char/pipe", char_pipe_test);
#endif
g_test_add_func("/char/file", char_file_test);
+ g_test_add_func("/char/file/pathin", char_file_separate_input_file);
#ifndef _WIN32
g_test_add_func("/char/file-fifo", char_file_fifo_test);
#endif
--
2.26.2
next prev parent reply other threads:[~2020-05-07 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 6:24 [PATCH v2 0/2] Add pathin option to -chardev file Alexander Bulekov
2020-05-07 6:24 ` [PATCH v2 1/2] chardev: enable distinct input for " Alexander Bulekov
2020-05-07 9:29 ` Darren Kenny
2020-05-07 6:24 ` Alexander Bulekov [this message]
2020-05-07 9:38 ` [PATCH v2 2/2] char-file: add test for distinct path= and pathin= Darren Kenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507062442.15215-3-alxndr@bu.edu \
--to=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).