From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37352C38A24 for ; Thu, 7 May 2020 14:48:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1BD420575 for ; Thu, 7 May 2020 14:48:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N59SsP/7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1BD420575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWhok-0000yW-6I for qemu-devel@archiver.kernel.org; Thu, 07 May 2020 10:48:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWhnd-0000HT-99 for qemu-devel@nongnu.org; Thu, 07 May 2020 10:46:57 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:57662 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWhnZ-0004p3-MW for qemu-devel@nongnu.org; Thu, 07 May 2020 10:46:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588862812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WAYK4DgJqN9PUL2KZHkmfLZ2ER+9wrR5OQMfEtdNCLw=; b=N59SsP/71LHimKTOGB30pPgMSWw3CvTdoEWqK1a/kZ5/WcmDYOfYKxS/iCb+Px9HVPmczH Hk4oME66DHygLFZxzk2RzDoiCJpFRK9JQrvizHYU8+eDTifwESoYU+6Uy/ukcW/D8f8sO3 5fFpxG39LzlxGLmAykwCFrpY/kp6jWQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-sunOIShEPDC7ITSAMPwS6g-1; Thu, 07 May 2020 10:46:49 -0400 X-MC-Unique: sunOIShEPDC7ITSAMPwS6g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 977858015CF; Thu, 7 May 2020 14:46:48 +0000 (UTC) Received: from work-vm (ovpn-114-224.ams2.redhat.com [10.36.114.224]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAF9160CCC; Thu, 7 May 2020 14:46:47 +0000 (UTC) Date: Thu, 7 May 2020 15:46:45 +0100 From: "Dr. David Alan Gilbert" To: Mao Zhongyi Subject: Re: [PATCH v2 0/3] Improved reporting for migrate parameters Message-ID: <20200507144645.GB17348@work-vm> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 02:00:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_HK_NAME_DR=0.01, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote: > This series mainly improve the report message of migrate parameters > to make it easier to read. Queued > v2->v1 > -p1: avoid using constants, replace it with stringify(). >=20 > Cc: quintela@redhat.com > Cc: dgilbert@redhat.com >=20 > Mao Zhongyi (3): > migration/migration: improve error reporting for migrate parameters > monitor/hmp-cmds: add hmp_handle_error() for hmp_migrate_set_speed() > migration: move the units of migrate parameters from milliseconds to > ms >=20 > migration/migration.c | 20 ++++++++++++-------- > monitor/hmp-cmds.c | 13 ++++++++----- > 2 files changed, 20 insertions(+), 13 deletions(-) >=20 > --=20 > 2.17.1 >=20 >=20 >=20 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK