From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Beata Michalska" <beata.michalska@linaro.org>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
qemu-arm@nongnu.org, "Keith Busch" <kbusch@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback
Date: Fri, 8 May 2020 08:24:53 +0200 [thread overview]
Message-ID: <20200508062456.23344-2-philmd@redhat.com> (raw)
In-Reply-To: <20200508062456.23344-1-philmd@redhat.com>
We usually use '_do_' for internal functions. Rename
memory_region_do_writeback() as memory_region_writeback().
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/exec/memory.h | 4 ++--
memory.c | 2 +-
target/arm/helper.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index e000bd2f97..1b7cfdd5b6 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1474,14 +1474,14 @@ void *memory_region_get_ram_ptr(MemoryRegion *mr);
void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize,
Error **errp);
/**
- * memory_region_do_writeback: Trigger cache writeback or msync for
+ * memory_region_writeback: Trigger cache writeback or msync for
* selected address range
*
* @mr: the memory region to be updated
* @addr: the initial address of the range to be written back
* @size: the size of the range to be written back
*/
-void memory_region_do_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size);
+void memory_region_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size);
/**
* memory_region_set_log: Turn dirty logging on or off for a region.
diff --git a/memory.c b/memory.c
index 601b749906..aa1f807392 100644
--- a/memory.c
+++ b/memory.c
@@ -2198,7 +2198,7 @@ void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, Error **errp
}
-void memory_region_do_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size)
+void memory_region_writeback(MemoryRegion *mr, hwaddr addr, hwaddr size)
{
/*
* Might be extended case needed to cover
diff --git a/target/arm/helper.c b/target/arm/helper.c
index a94f650795..c4710b7371 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -6829,7 +6829,7 @@ static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque,
mr = memory_region_from_host(haddr, &offset);
if (mr) {
- memory_region_do_writeback(mr, offset, dline_size);
+ memory_region_writeback(mr, offset, dline_size);
}
}
}
--
2.21.3
next prev parent reply other threads:[~2020-05-08 6:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:24 [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Philippe Mathieu-Daudé
2020-05-08 6:24 ` Philippe Mathieu-Daudé [this message]
2020-05-08 20:16 ` [PATCH 1/4] memory: Rename memory_region_do_writeback -> memory_region_writeback Richard Henderson
2020-05-08 6:24 ` [PATCH 2/4] memory: Extract memory_region_msync() from memory_region_writeback() Philippe Mathieu-Daudé
2020-05-08 6:24 ` [PATCH 3/4] hw/block: Let the NVMe emulated device be target-agnostic Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:24 ` [PATCH 4/4] exec: Rename qemu_ram_writeback() as qemu_ram_msync() Philippe Mathieu-Daudé
2020-05-08 20:25 ` Richard Henderson
2020-05-08 6:33 ` [PATCH 0/4] memory: Add memory_region_msync() & make NVMe emulated device generic Paolo Bonzini
2020-05-08 15:20 ` Beata Michalska
2020-05-08 15:33 ` Paolo Bonzini
2020-05-08 15:34 ` Philippe Mathieu-Daudé
2020-05-08 15:35 ` Philippe Mathieu-Daudé
2020-05-08 15:58 ` Paolo Bonzini
2020-05-21 12:32 ` Stefan Hajnoczi
2020-05-21 12:46 ` Paolo Bonzini
2020-05-21 14:21 ` Philippe Mathieu-Daudé
2020-05-27 12:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508062456.23344-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).