From: Kevin Wolf <kwolf@redhat.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: "Beata Michalska" <beata.michalska@linaro.org>,
qemu-block@nongnu.org, "Klaus Jensen" <k.jensen@samsung.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Javier Gonzalez" <javier.gonz@samsung.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v5 00/18] nvme: refactoring and cleanups
Date: Mon, 11 May 2020 14:50:11 +0200 [thread overview]
Message-ID: <20200511125011.GD5661@linux.fritz.box> (raw)
In-Reply-To: <20200511070936.fxarxicz7zrj6mop@apples.localdomain>
Am 11.05.2020 um 09:09 hat Klaus Jensen geschrieben:
> On May 11 09:00, Philippe Mathieu-Daudé wrote:
> > Hi Klaus,
> >
> > On 5/11/20 8:25 AM, Klaus Jensen wrote:
> > > On May 5 07:48, Klaus Jensen wrote:
> > > > From: Klaus Jensen <k.jensen@samsung.com>
> > > >
> > > > Changes since v5
> > > > ~~~~~~~~~~~~~~~~
> > > > No functional changes, just updated Reviewed-by tags. Also, I screwed up
> > > > the CC list when sending v4.
> > > >
> > > > Philippe and Keith, please add a Reviewed-by to
> > > >
> > > > * "nvme: factor out pmr setup" and
> > > > * "do cmb/pmr init as part of pci init"
> > > >
> > > > since the first one was added and the second one was changed in v4 when
> > > > rebasing on Kevins block-next tree which had the PMR work that was not
> > > > in master at the time.
> > > >
> > > > With those in place, it should be ready for Kevin to merge.
> > > >
> > > Gentle ping on this.
> > >
> > > Also, please see the two patches in "[PATCH 0/2] hw/block/nvme: fixes
> > > for interrupt behavior". I think they should go in preparation to this
> > > series.
> >
> > I was going to ping Kevin last week, but then read your comment on pach #7
> > "nvme: add max_ioqpairs device parameter", so I interpreted you would
> > respin.
> > Now it is clearer, applying in the following order you don't need to respin,
> > right?
> >
> > - [PATCH 0/2] hw/block/nvme: fixes for interrupt behavior"
> > - [PATCH v5 00/18] nvme: refactoring and cleanups
I was waiting for the review Klaus asked for. You had a comment about
renaming patches, but I didn't see any comments about the patches in
question.
> Ugh. "[PATCH v5 00/18] nvme: refactoring and cleanups" doesn't apply
> completely cleanly.
>
> "[PATCH 0/2] hw/block/nvme: fixes for interrupt behavior" was intented
> to go into master because it fixes a bug, that is why I split them up.
>
> But looks like it is better to just roll it into this series. I'll
> respin a v6 with the two interrupt fixes.
Ok, I'll wait for that one then. I'm still not sure, though, whether I
should then wait for additional review or just apply the patches.
Kevin
prev parent reply other threads:[~2020-05-11 12:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 5:48 [PATCH v5 00/18] nvme: refactoring and cleanups Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 01/18] nvme: fix pci doorbell size calculation Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 02/18] nvme: rename trace events to pci_nvme Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 03/18] nvme: remove superfluous breaks Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 04/18] nvme: move device parameters to separate struct Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 05/18] nvme: use constants in identify Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 06/18] nvme: refactor nvme_addr_read Klaus Jensen
2020-05-05 5:52 ` Klaus Jensen
2020-05-05 12:10 ` Maxim Levitsky
2020-05-05 5:48 ` [PATCH v5 07/18] nvme: add max_ioqpairs device parameter Klaus Jensen
2020-05-05 20:52 ` Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 08/18] nvme: remove redundant cmbloc/cmbsz members Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 09/18] nvme: factor out property/constraint checks Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 10/18] nvme: factor out device state setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 11/18] nvme: factor out block backend setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 12/18] nvme: add namespace helpers Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 13/18] nvme: factor out namespace setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 14/18] nvme: factor out pci setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 15/18] nvme: factor out cmb setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 16/18] nvme: factor out pmr setup Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 17/18] nvme: do cmb/pmr init as part of pci init Klaus Jensen
2020-05-05 5:48 ` [PATCH v5 18/18] nvme: factor out controller identify setup Klaus Jensen
2020-05-05 9:41 ` [PATCH v5 00/18] nvme: refactoring and cleanups Philippe Mathieu-Daudé
2020-05-11 6:25 ` Klaus Jensen
2020-05-11 7:00 ` Philippe Mathieu-Daudé
2020-05-11 7:09 ` Klaus Jensen
2020-05-11 12:50 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511125011.GD5661@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=its@irrelevant.dk \
--cc=javier.gonz@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).