* [PATCH v1 0/1] target/microblaze: Fix mfs from EDR
@ 2020-05-12 14:36 Edgar E. Iglesias
2020-05-12 14:36 ` [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation Edgar E. Iglesias
0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2020-05-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, frederic.konrad,
tong.ho, philmd, luc.michel
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
We're missing mfs from EDR support, this adds it.
Showed up in Xilinx Versal PLM code.
Cheers,
Edgar
Tong Ho (1):
target/microblaze: Add MFS Rd,EDR translation
target/microblaze/translate.c | 1 +
1 file changed, 1 insertion(+)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation
2020-05-12 14:36 [PATCH v1 0/1] target/microblaze: Fix mfs from EDR Edgar E. Iglesias
@ 2020-05-12 14:36 ` Edgar E. Iglesias
2020-05-13 7:42 ` Luc Michel
0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2020-05-12 14:36 UTC (permalink / raw)
To: qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, frederic.konrad,
tong.ho, philmd, luc.michel
From: Tong Ho <tong.ho@xilinx.com>
This is to fix cpu-abort with 'qemu: fatal: unknown mfs reg d'
(in the default case) when microblaze guest issues 'MFS Rd,EDR'
instruction.
Since embeddedsw release 2019.2, XPlm_ExceptionHandler() issues
the instruction on exception, and microblaze model aborts when
PLM firmware guest encounters an exception.
Signed-off-by: Tong Ho <tong.ho@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
target/microblaze/translate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 20b7427811..92b3630804 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -581,6 +581,7 @@ static void dec_msr(DisasContext *dc)
case SR_ESR:
case SR_FSR:
case SR_BTR:
+ case SR_EDR:
tcg_gen_extrl_i64_i32(cpu_R[dc->rd], cpu_SR[sr]);
break;
case 0x800:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation
2020-05-12 14:36 ` [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation Edgar E. Iglesias
@ 2020-05-13 7:42 ` Luc Michel
0 siblings, 0 replies; 3+ messages in thread
From: Luc Michel @ 2020-05-13 7:42 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel
Cc: figlesia, peter.maydell, sstabellini, edgar.iglesias,
sai.pavan.boddu, frasse.iglesias, alistair, frederic.konrad,
tong.ho, philmd
On 5/12/20 4:36 PM, Edgar E. Iglesias wrote:
> From: Tong Ho <tong.ho@xilinx.com>
>
> This is to fix cpu-abort with 'qemu: fatal: unknown mfs reg d'
> (in the default case) when microblaze guest issues 'MFS Rd,EDR'
> instruction.
>
> Since embeddedsw release 2019.2, XPlm_ExceptionHandler() issues
> the instruction on exception, and microblaze model aborts when
> PLM firmware guest encounters an exception.
>
> Signed-off-by: Tong Ho <tong.ho@xilinx.com>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
> ---
> target/microblaze/translate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 20b7427811..92b3630804 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -581,6 +581,7 @@ static void dec_msr(DisasContext *dc)
> case SR_ESR:
> case SR_FSR:
> case SR_BTR:
> + case SR_EDR:
> tcg_gen_extrl_i64_i32(cpu_R[dc->rd], cpu_SR[sr]);
> break;
> case 0x800:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-13 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 14:36 [PATCH v1 0/1] target/microblaze: Fix mfs from EDR Edgar E. Iglesias
2020-05-12 14:36 ` [PATCH v1 1/1] target/microblaze: Add MFS Rd,EDR translation Edgar E. Iglesias
2020-05-13 7:42 ` Luc Michel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).