From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910B7C54E8F for ; Tue, 12 May 2020 14:17:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6096C206D3 for ; Tue, 12 May 2020 14:17:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NOD1kyY5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6096C206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYVis-0004RL-H0 for qemu-devel@archiver.kernel.org; Tue, 12 May 2020 10:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYVga-0002NH-9c for qemu-devel@nongnu.org; Tue, 12 May 2020 10:15:08 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56609 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jYVgZ-0001wk-Db for qemu-devel@nongnu.org; Tue, 12 May 2020 10:15:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589292905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2NMijGmhQfi+bbo11NyY2WASs+KWi/cO/qiUqTmweU=; b=NOD1kyY5OTmyMbj2/y1Ev/G82tU32zHQLBivElnY6eVhDDKAJ95c3qYChdUn6oGjpWZSW2 XpVPZHv63CWFWrCDXbCP3pBAZ8oQ51isVbMpNCIURmuZfxn9zCJdpm5+7CEM2XZzq7BlK3 0yoYz0xG2FNBcnz/L4D5c1f9AxzghJ8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-OPuvBqDAPsq-suwyHKYgIg-1; Tue, 12 May 2020 10:15:04 -0400 X-MC-Unique: OPuvBqDAPsq-suwyHKYgIg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4DFC1009600; Tue, 12 May 2020 14:15:02 +0000 (UTC) Received: from localhost (unknown [10.40.208.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F24B10001B2; Tue, 12 May 2020 14:14:50 +0000 (UTC) Date: Tue, 12 May 2020 16:14:47 +0200 From: Igor Mammedov To: "Michael S. Tsirkin" Subject: Re: [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part Message-ID: <20200512161447.07b76de2@redhat.com> In-Reply-To: <20200506055747-mutt-send-email-mst@kernel.org> References: <20200505144419.29174-1-eric.auger@redhat.com> <20200505144419.29174-2-eric.auger@redhat.com> <20200506063314.4qvnyfonjixcknuj@kamzik.brq.redhat.com> <20200506055747-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 02:02:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Andrew Jones , gshan@redhat.com, shannon.zhaosl@gmail.com, qemu-devel@nongnu.org, Eric Auger , qemu-arm@nongnu.org, marcandre.lureau@redhat.com, eric.auger.pro@gmail.com, lersek@redhat.com, ardb@kernel.org, stefanb@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 6 May 2020 05:58:25 -0400 "Michael S. Tsirkin" wrote: > On Wed, May 06, 2020 at 08:33:14AM +0200, Andrew Jones wrote: > > I realize this function is just getting moved, but maybe it should get > > converted to the build_append* API while being moved? > > I'd rather refactoring was done in a separate patch - > easier to review. maybe first convert and then move PS: me wonders if we have test with TPM enabled, if not maybe it's time to add them i.e. first goes testcase in bios-tables and then refactoring/moving in that case review is simpler.