Re: [PATCH v1 0/4] target/microblaze: Add dynamic GDB XML and correct SReg reporting

["Edgar E. Iglesias" <edgar.iglesias@xilinx.com>]

On Mon, May 11, 2020 at 10:05:47AM -0700, Joe Komlodi wrote:
> Hi all,
> 
> This series adds dynamic GDB XML support for Micraoblaze CPUs, and fixes
> an issue when reporting Microblaze SRegs through GDB.
> 
> The SRegs used to be printed out by iterating over the SReg array, but the
> SReg array isn't laid out in memory in the same order that GDB expects them.
> 
> When reporting register to GDB, note that even though 32-bit Microblaze
> supports having certain registers wider than 32-bits, we're repoting all of
> them as being 32-bits wide right now to maintain compatibility with GDB.
> 
> Thanks!
> Joe


Thanks Joe!
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> 
> Joe Komlodi (4):
>   target/microblaze: gdb: Add dynamic GDB XML register support
>   target/microblaze: gdb: Extend the number of registers presented to
>     GDB
>   target/microblaze: gdb: Fix incorrect SReg reporting
>   target/microblaze: monitor: Increase the number of registers reported
> 
>  configure                     |   1 +
>  target/microblaze/cpu.c       |   6 +-
>  target/microblaze/cpu.h       |   9 ++
>  target/microblaze/gdbstub.c   | 214 +++++++++++++++++++++++++++++++++++++++++-
>  target/microblaze/translate.c |  16 +++-
>  5 files changed, 240 insertions(+), 6 deletions(-)
> 
> -- 
> 2.7.4
>