qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [RISU 4/9] Adjust tracefile open for write
Date: Wed, 13 May 2020 11:09:48 -0700	[thread overview]
Message-ID: <20200513180953.20376-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200513180953.20376-1-richard.henderson@linaro.org>

Truncate the new output file.  Rely on umask to remove
group+other file permissions, if desired.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 risu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/risu.c b/risu.c
index 1c66885..f404d8f 100644
--- a/risu.c
+++ b/risu.c
@@ -368,7 +368,7 @@ int main(int argc, char **argv)
             comm_fd = ismaster ? STDOUT_FILENO : STDIN_FILENO;
         } else {
             if (ismaster) {
-                comm_fd = open(trace_fn, O_WRONLY | O_CREAT, S_IRWXU);
+                comm_fd = open(trace_fn, O_WRONLY | O_CREAT | O_TRUNC, 0666);
             } else {
                 comm_fd = open(trace_fn, O_RDONLY);
             }
-- 
2.20.1



  parent reply	other threads:[~2020-05-13 18:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 18:09 [RISU 0/9] risu cleanups and improvements Richard Henderson
2020-05-13 18:09 ` [RISU 1/9] Use bool for tracing variables Richard Henderson
2020-05-18 15:51   ` Peter Maydell
2020-05-13 18:09 ` [RISU 2/9] Unify master_fd and apprentice_fd to comm_fd Richard Henderson
2020-05-18 15:51   ` Peter Maydell
2020-05-13 18:09 ` [RISU 3/9] Hoist trace file opening Richard Henderson
2020-05-18 15:52   ` Peter Maydell
2020-05-13 18:09 ` Richard Henderson [this message]
2020-05-18 15:53   ` [RISU 4/9] Adjust tracefile open for write Peter Maydell
2020-05-13 18:09 ` [RISU 5/9] Use EXIT_FAILURE, EXIT_SUCCESS Richard Henderson
2020-05-18 15:54   ` Peter Maydell
2020-05-18 16:46     ` Richard Henderson
2020-05-13 18:09 ` [RISU 6/9] Add magic and size to the trace header Richard Henderson
2020-05-13 18:09 ` [RISU 7/9] Compute reginfo_size based on the reginfo Richard Henderson
2020-05-13 18:09 ` [RISU 8/9] aarch64: Reorg sve reginfo to save space Richard Henderson
2020-05-13 18:09 ` [RISU 9/9] Add --dump option to inspect trace files Richard Henderson
2020-05-18 18:39 ` [RISU 0/9] risu cleanups and improvements Peter Maydell
2020-05-18 19:14   ` Alex Bennée
2020-05-18 19:33   ` Richard Henderson
2020-05-18 19:43     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513180953.20376-5-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).