From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pkrempa@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, John Snow <jsnow@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
vsementsov@virtuozzo.com, Cleber Rosa <crosa@redhat.com>
Subject: [PATCH RFC v2 0/5] block: add block-dirty-bitmap-populate job
Date: Wed, 13 May 2020 23:49:17 -0400 [thread overview]
Message-ID: <20200514034922.24834-1-jsnow@redhat.com> (raw)
Hi,
This is a new (very small) block job that writes a pattern into a
bitmap. The only pattern implemented is the top allocation information.
This can be used to "recover" an incremental bitmap chain if an external
snapshot was taken without creating a new bitmap first: any writes made
to the image will be reflected by the allocation status and can be
written back into a bitmap.
This is useful for e.g. libvirt managing backup chains if a user creates
an external snapshot outside of libvirt.
v2:
- Addressed some, but not all feedback
- Rebased on latest 'job-runner' series; but it's not clear if it
should be kept.
- This version doesn't address all of the feedback from v1,
but I am posting it to the list as an RFC.
John Snow (5):
block: add bitmap-populate job
blockdev: combine DriveBackupState and BlockdevBackupState
qmp: expose block-dirty-bitmap-populate
iotests: move bitmap helpers into their own file
iotests: add 287 for block-dirty-bitmap-populate
qapi/block-core.json | 66 +
qapi/job.json | 2 +-
qapi/transaction.json | 2 +
include/block/block_int.h | 21 +
block/bitmap-alloc.c | 207 ++
blockdev.c | 104 +-
blockjob.c | 3 +-
block/Makefile.objs | 1 +
tests/qemu-iotests/257 | 110 +-
tests/qemu-iotests/287 | 242 ++
tests/qemu-iotests/287.out | 4544 +++++++++++++++++++++++++++++++++
tests/qemu-iotests/bitmaps.py | 131 +
tests/qemu-iotests/group | 1 +
13 files changed, 5305 insertions(+), 129 deletions(-)
create mode 100644 block/bitmap-alloc.c
create mode 100755 tests/qemu-iotests/287
create mode 100644 tests/qemu-iotests/287.out
create mode 100644 tests/qemu-iotests/bitmaps.py
--
2.21.1
next reply other threads:[~2020-05-14 3:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 3:49 John Snow [this message]
2020-05-14 3:49 ` [PATCH RFC v2 1/5] block: add bitmap-populate job John Snow
2020-05-18 20:49 ` Eric Blake
2020-05-19 8:27 ` Peter Krempa
2020-06-04 9:12 ` Kevin Wolf
2020-06-04 9:16 ` Peter Krempa
2020-06-04 11:31 ` Kevin Wolf
2020-06-04 16:22 ` Peter Krempa
2020-06-05 9:01 ` Kevin Wolf
2020-06-05 9:24 ` Peter Krempa
2020-06-05 9:44 ` Kevin Wolf
2020-06-05 9:58 ` Peter Krempa
2020-06-05 10:07 ` Kevin Wolf
2020-06-05 10:59 ` Peter Krempa
2020-06-06 6:55 ` Vladimir Sementsov-Ogievskiy
2020-06-08 9:21 ` Kevin Wolf
2020-06-08 10:00 ` Vladimir Sementsov-Ogievskiy
2020-06-08 13:15 ` Kevin Wolf
2020-06-08 9:38 ` Peter Krempa
2020-06-08 10:30 ` Vladimir Sementsov-Ogievskiy
2020-06-08 12:01 ` Peter Krempa
2020-06-04 9:01 ` Kevin Wolf
2020-06-16 19:46 ` Eric Blake
2020-06-16 19:51 ` John Snow
2020-06-16 20:02 ` Eric Blake
2020-06-17 10:57 ` Kevin Wolf
2020-05-14 3:49 ` [PATCH RFC v2 2/5] blockdev: combine DriveBackupState and BlockdevBackupState John Snow
2020-05-18 20:57 ` Eric Blake
2020-05-14 3:49 ` [PATCH RFC v2 3/5] qmp: expose block-dirty-bitmap-populate John Snow
2020-05-18 21:10 ` Eric Blake
2020-05-14 3:49 ` [PATCH RFC v2 4/5] iotests: move bitmap helpers into their own file John Snow
2020-05-14 3:49 ` [PATCH RFC v2 5/5] iotests: add 287 for block-dirty-bitmap-populate John Snow
2020-05-18 21:22 ` Eric Blake
2020-06-04 9:24 ` Kevin Wolf
2020-05-18 14:52 ` [PATCH RFC v2 0/5] block: add block-dirty-bitmap-populate job Peter Krempa
2020-06-09 15:04 ` Peter Krempa
2020-06-05 21:51 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514034922.24834-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).