From: Raphael Pour <raphael.pour@hetzner.com>
To: Eric Blake <eblake@redhat.com>
Cc: Raphael Pour <raphael.pour@hetzner.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Subject: [PATCH v2 0/1] qemu-nbd: Close inherited stderr
Date: Thu, 14 May 2020 08:31:11 +0200 [thread overview]
Message-ID: <20200514063112.1457125-1-raphael.pour@hetzner.com> (raw)
In-Reply-To: <1jYr2L-0004mc-Jj@mail.hetzner.company>
Hello,
introduced with e6df58a5, stderr won't get closed if the fork option is
set. This causes other processes reading stderr to block infinietly or
crash while relying on EOF.
v2:
- Instead of closing the inherited stderr in the child, avoid the dup
in the parent if the fork option is not set.
Raphael Pour (1):
qemu-nbd: Close inherited stderr
qemu-nbd.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--
2.25.4
next parent reply other threads:[~2020-05-14 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1jYr2L-0004mc-Jj@mail.hetzner.company>
2020-05-14 6:31 ` Raphael Pour [this message]
2020-05-14 6:31 ` [PATCH v2 1/1] qemu-nbd: Close inherited stderr Raphael Pour
2020-05-14 12:51 ` [PATCH v2 0/1] " no-reply
2020-05-14 14:29 ` Eric Blake
2020-05-14 14:55 ` Eric Blake
2020-05-15 6:36 ` Raphael Pour
2020-05-15 17:31 ` Eric Blake
2020-05-14 6:35 ` Raphael Pour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514063112.1457125-1-raphael.pour@hetzner.com \
--to=raphael.pour@hetzner.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).