qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Raphael Pour <raphael.pour@hetzner.com>
To: Eric Blake <eblake@redhat.com>
Cc: Raphael Pour <raphael.pour@hetzner.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	qemu-stable@nongnu.org
Subject: [PATCH v2 1/1] qemu-nbd: Close inherited stderr
Date: Thu, 14 May 2020 08:31:12 +0200	[thread overview]
Message-ID: <20200514063112.1457125-2-raphael.pour@hetzner.com> (raw)
In-Reply-To: <20200514063112.1457125-1-raphael.pour@hetzner.com>

Close inherited stderr of the parent if fork_process is false.
Otherwise no one will close it. (introduced by e6df58a5)
---
 qemu-nbd.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index 4aa005004e..a324d21c5e 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -916,7 +916,13 @@ int main(int argc, char **argv)
         } else if (pid == 0) {
             close(stderr_fd[0]);
 
-            old_stderr = dup(STDERR_FILENO);
+            /* Remember parents stderr only if the fork option is set.
+             * The child won't close this inherited fd otherwise.
+             */
+            if (fork_process) {
+              old_stderr = dup(STDERR_FILENO);
+            }
+
             ret = qemu_daemon(1, 0);
 
             /* Temporarily redirect stderr to the parent's pipe...  */
-- 
2.25.4



  reply	other threads:[~2020-05-14  6:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1jYr2L-0004mc-Jj@mail.hetzner.company>
2020-05-14  6:31 ` [PATCH v2 0/1] qemu-nbd: Close inherited stderr Raphael Pour
2020-05-14  6:31   ` Raphael Pour [this message]
2020-05-14 12:51   ` no-reply
2020-05-14 14:29     ` Eric Blake
2020-05-14 14:55       ` Eric Blake
2020-05-15  6:36       ` Raphael Pour
2020-05-15 17:31         ` Eric Blake
2020-05-14  6:35 ` Raphael Pour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514063112.1457125-2-raphael.pour@hetzner.com \
    --to=raphael.pour@hetzner.com \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).