From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Joe Komlodi <joe.komlodi@xilinx.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH V2 4/4] target/microblaze: monitor: Increase the number of registers reported
Date: Thu, 14 May 2020 15:50:15 +0200 [thread overview]
Message-ID: <20200514135015.GT2945@toto> (raw)
In-Reply-To: <1589393329-223076-4-git-send-email-komlodi@xilinx.com>
On Wed, May 13, 2020 at 11:08:48AM -0700, Joe Komlodi wrote:
> Increase the number of registers reported to match GDB.
>
> Registers that aren't modeled are reported as 0.
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Signed-off-by: Joe Komlodi <komlodi@xilinx.com>
> ---
> target/microblaze/translate.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 20b7427..4e7f903a 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1788,9 +1788,11 @@ void mb_cpu_dump_state(CPUState *cs, FILE *f, int flags)
> qemu_fprintf(f, "IN: PC=%" PRIx64 " %s\n",
> env->sregs[SR_PC], lookup_symbol(env->sregs[SR_PC]));
> qemu_fprintf(f, "rmsr=%" PRIx64 " resr=%" PRIx64 " rear=%" PRIx64 " "
> - "debug=%x imm=%x iflags=%x fsr=%" PRIx64 "\n",
> + "debug=%x imm=%x iflags=%x fsr=%" PRIx64 " "
> + "rbtr=%" PRIx64 "\n",
> env->sregs[SR_MSR], env->sregs[SR_ESR], env->sregs[SR_EAR],
> - env->debug, env->imm, env->iflags, env->sregs[SR_FSR]);
> + env->debug, env->imm, env->iflags, env->sregs[SR_FSR],
> + env->sregs[SR_BTR]);
> qemu_fprintf(f, "btaken=%d btarget=%" PRIx64 " mode=%s(saved=%s) "
> "eip=%d ie=%d\n",
> env->btaken, env->btarget,
> @@ -1798,7 +1800,17 @@ void mb_cpu_dump_state(CPUState *cs, FILE *f, int flags)
> (env->sregs[SR_MSR] & MSR_UMS) ? "user" : "kernel",
> (bool)(env->sregs[SR_MSR] & MSR_EIP),
> (bool)(env->sregs[SR_MSR] & MSR_IE));
> + for (i = 0; i < 12; i++) {
> + qemu_fprintf(f, "rpvr%2.2d=%8.8x ", i, env->pvr.regs[i]);
> + if ((i + 1) % 4 == 0) {
> + qemu_fprintf(f, "\n");
> + }
> + }
>
> + /* Registers that aren't modeled are reported as 0 */
> + qemu_fprintf(f, "redr=%" PRIx64 " rpid=0 rzpr=0 rtlbx=0 rtlbsx=0 "
> + "rtlblo=0 rtlbhi=0\n", env->sregs[SR_EDR]);
> + qemu_fprintf(f, "slr=%x shr=%x\n", env->slr, env->shr);
> for (i = 0; i < 32; i++) {
> qemu_fprintf(f, "r%2.2d=%8.8x ", i, env->regs[i]);
> if ((i + 1) % 4 == 0)
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-05-14 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 18:08 [PATCH V2 1/4] target/microblaze: gdb: Add dynamic GDB XML register support Joe Komlodi
2020-05-13 18:08 ` [PATCH V2 2/4] target/microblaze: gdb: Extend the number of registers presented to GDB Joe Komlodi
2020-05-14 13:49 ` Edgar E. Iglesias
2020-05-13 18:08 ` [PATCH V2 3/4] target/microblaze: gdb: Fix incorrect SReg reporting Joe Komlodi
2020-05-14 13:50 ` Edgar E. Iglesias
2020-05-13 18:08 ` [PATCH V2 4/4] target/microblaze: monitor: Increase the number of registers reported Joe Komlodi
2020-05-14 13:50 ` Edgar E. Iglesias [this message]
2020-05-13 18:08 ` [PATCH V2 0/4] target/microblaze: Add GDB XML and correct SReg reporting Joe Komlodi
2020-05-14 13:52 ` Edgar E. Iglesias
2020-05-14 13:41 ` [PATCH V2 1/4] target/microblaze: gdb: Add dynamic GDB XML register support Edgar E. Iglesias
2020-05-14 17:05 ` Joe Komlodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514135015.GT2945@toto \
--to=edgar.iglesias@xilinx.com \
--cc=joe.komlodi@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).