From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B9EC433E0 for ; Fri, 15 May 2020 08:57:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6A78206B6 for ; Fri, 15 May 2020 08:57:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ax1Z+2C9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6A78206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZW9u-0005MT-4g for qemu-devel@archiver.kernel.org; Fri, 15 May 2020 04:57:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZW94-00040y-O4 for qemu-devel@nongnu.org; Fri, 15 May 2020 04:56:42 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:40402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZW93-0006nH-LH for qemu-devel@nongnu.org; Fri, 15 May 2020 04:56:42 -0400 Received: by mail-wm1-x342.google.com with SMTP id u16so1738145wmc.5 for ; Fri, 15 May 2020 01:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Yz533la2Uoo7DomaE8kxRmv2gaoFr5wBiUEX8eW1fQY=; b=ax1Z+2C9wuTQRnHckhtLfpMuZDwn3qYC5AuBZq0xMAnPEVy1JXwJjOv7CpeR14hFx0 gajyMED3Cmark8yZTwBN93D4Ff7ESmIMp8E64sckozV2KQtU0MBP/5KzhyMCA4OkpZX8 dS02BQDBGf2klGJTGpnqe2jNXRJAhNssRuU/xT17zXXN1fC1CXejAdflQfRdC4uy5FuM 10aFy+2yyF52Vb9XqrYATQv1LYgE6FJt6ofnHfqzrsMa/4io9LkmRiBED7X94TMPVwCN iD/yVM1Xq6mME+KrWslhOg+dzY9QF3+ztvafiAahd2ypPK24Fw9xXwYsM0umYlTJyjIA 91YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Yz533la2Uoo7DomaE8kxRmv2gaoFr5wBiUEX8eW1fQY=; b=tfXTRiAdJr9g9VzD0Uxrm6QqHSfIFDgzwHUJ8Kif0JHiweIYfYYNqUjI98bW4UtQ6U 5S19Pi7CAtLA3vrkn4NVbq5XK5UJtQDwFr/8TccQoiOdBIa1CaIB8AZVufrhEC7IKHzx s0FAdsm8v1Mqptw2sidFPqZ7/+RoQPxpoeNVGxNrXsiMFX65nnHtgH+mIaUPScwdy/mw e5e07jf0L6NGxs+6DL0d4FM6NO7VJzZxbFO72mXRaSnnvlapSjC+Di9h5SFuglEjGgd1 w33M5/rWxSxJnp6DG/gYtEWCT60k9WWqczL0jTP/As3pVqM5JLWtRwPofSrR42lmbTw4 W9xA== X-Gm-Message-State: AOAM533fz0Md1T+AjYSKz0fwhb8D2jJszXKuRFC6X+xeI2eqSrjgARfy sZNLNN9v+DNdM4m3AlR5Q4c= X-Google-Smtp-Source: ABdhPJyFxpeSyx25PKO2bfrB349XgwIdiNEjXZabqS1q742L6n9nUSpVKAv2pS3VtVuP6WjOwqGx1Q== X-Received: by 2002:a1c:6182:: with SMTP id v124mr2912017wmb.30.1589532999583; Fri, 15 May 2020 01:56:39 -0700 (PDT) Received: from jondnuc (IGLD-84-229-154-20.inter.net.il. [84.229.154.20]) by smtp.gmail.com with ESMTPSA id y185sm2573102wmy.11.2020.05.15.01.56.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 01:56:38 -0700 (PDT) Date: Fri, 15 May 2020 11:56:36 +0300 From: Jon Doron To: Igor Mammedov Subject: Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry Message-ID: <20200515085636.GN2862@jondnuc> References: <20200424123444.3481728-1-arilou@gmail.com> <20200424123444.3481728-6-arilou@gmail.com> <20200505150637.7131e79b@redhat.com> <20200505153838.GC2862@jondnuc> <30fea22b-ef36-04d9-17ef-d13e3f93a3c5@maciej.szmigiero.name> <20200507031425.GG2862@jondnuc> <20200511201106.GB1307176@rvkaganb.lan> <20200513173725.277b0e16@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200513173725.277b0e16@redhat.com> Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=arilou@gmail.com; helo=mail-wm1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Maciej S. Szmigiero" , eyakovlev@virtuozzo.com, ehabkost@redhat.com, qemu-devel@nongnu.org, Roman Kagan , liran.alon@oracle.com, Roman Kagan , pbonzini@redhat.com, vkuznets@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13/05/2020, Igor Mammedov wrote: Do you guys know perhaps which module is reading the ACPI configuration for VMBus? vmbus.sys / vmbkmcl.sys / winhv.sys? is it the kernel or HAL? I dont have any real HyperV Windows to play with... Roman, do you remember when is this information being used? Do we need a full emulation setup (aka your hv-scsi / hv-net) patches in order to see Windows working this ACPI entry? Thanks, -- Jon. >On Mon, 11 May 2020 23:11:23 +0300 >Roman Kagan wrote: > >> On Thu, May 07, 2020 at 06:14:25AM +0300, Jon Doron wrote: >> > Igor it seems like the IRQ being used is 5 and not 7 & 13 like in the >> > current patch. >> >> HyperV using irq 5 doesn't mean QEMU has to too. Especially so as no >> guest was noticed to use the irqs in ACPI. I'd rather try and test if >> the guest requires any those at all. >> >> > Seems like it needs to reside in the _CRS like you said. >> >> They already are there. >> >> > Seems like it has all those _STA/_DIS/_PS0 just like the way it's currently >> > in the patch (unless I'm missing something). >> >> Right, but, as you can see, they are pretty dumb, so the question is >> whether they are necessary or the guests can do without (Linux >> apparently can). > >Agreed with all of above, >Instead of blind copying dubious AML, we should try to figure out what's >really necessary of it and throw away the rest. > >> >> Thanks, >> Roman. >> >> > Notice _PS3 is not a Method. >> > >> > So just to summarize the changes i need to do: >> > 1. Change from 2 IRQs to single one (and use 5 as the default) >> > 2. IRQs needs to be under _CRS. >> > 3. You mentioned you want under a different location than the ISA bug where >> > would you want it to be? >> > >> > Please let me know if there is anything else. >> > >> > Thanks, >> > -- Jon. >> > >> > On 06/05/2020, Maciej S. Szmigiero wrote: >> > > On 05.05.2020 17:38, Jon Doron wrote: >> > > > On 05/05/2020, Igor Mammedov wrote: >> > > > >> > > > I dont know what were the original intentions of the original patch authors (at this point I simply rebased it, and to be honest I did not need this patch to get where I was going to, but it was part of the original patchset). >> > > > >> > > > But I'm willing to do any changes so we can keep going forward with this. >> > > > >> > > > > On Fri, 24 Apr 2020 15:34:43 +0300 >> > > > > Jon Doron wrote: >> > > > > >> > > > > > Guest OS uses ACPI to discover VMBus presence.  Add a corresponding >> > > > > > entry to DSDT in case VMBus has been enabled. >> > > > > > >> > > > > > Experimentally Windows guests were found to require this entry to >> > > > > > include two IRQ resources. They seem to never be used but they still >> > > > > > have to be there. >> > > > > > >> > > > > > Make IRQ numbers user-configurable via corresponding properties; use 7 >> > > > > > and 13 by default. >> > > > > well, it seems that at least linux guest driver uses one IRQ, >> > > > > abeit not from ACPI descriptior >> > > > > >> > > > > perhaps it's what hyperv host puts into _CRS. >> > > > > Could you dump ACPI tables and check how hyperv describes vmbus in acpi? >> > > > > >> > > > > >> > > > >> > > > I can no longer get to the HyperV computer I had (in the office so hopefully if someone else has access to HyperV machine and willing to reply here with the dumped ACPI tables that would be great). >> > > > >> > > >> > > Here is a VMBus ACPI device description from Hyper-V in Windows Server 2019: >> > > >> > > Device (\_SB.VMOD.VMBS) >> > > { >> > > Name (STA, 0x0F) >> > > Name (_ADR, Zero) // _ADR: Address >> > > Name (_DDN, "VMBUS") // _DDN: DOS Device Name >> > > Name (_HID, "VMBus") // _HID: Hardware ID >> > > Name (_UID, Zero) // _UID: Unique ID >> > > Method (_DIS, 0, NotSerialized) // _DIS: Disable Device >> > > { >> > > STA &= 0x0D >> > > } >> > > >> > > Method (_PS0, 0, NotSerialized) // _PS0: Power State 0 >> > > { >> > > STA |= 0x0F >> > > } >> > > >> > > Method (_STA, 0, NotSerialized) // _STA: Status >> > > { >> > > Return (STA) /* \_SB_.VMOD.VMBS.STA_ */ >> > > } >> > > >> > > Name (_PS3, Zero) // _PS3: Power State 3 >> > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings >> > > { >> > > IRQ (Edge, ActiveHigh, Exclusive, ) >> > > {5} >> > > }) >> > > } >> > > >> > > It seems to use just IRQ 5. >> > > >> > > Maciej >> > >> >