* [PATCH] hw/ide/ahci: Log lost IRQs
@ 2020-05-04 9:48 Philippe Mathieu-Daudé
2020-05-12 6:53 ` Philippe Mathieu-Daudé
2020-05-14 20:20 ` John Snow
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-04 9:48 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, Philippe Mathieu-Daudé, qemu-block
One might find interesting to look at AHCI IRQs.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/ide/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 13d91e109a..fc82cbd5f1 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
static void ahci_irq_set(void *opaque, int n, int level)
{
+ qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
}
static const IDEDMAOps ahci_dma_ops = {
--
2.21.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw/ide/ahci: Log lost IRQs
2020-05-04 9:48 [PATCH] hw/ide/ahci: Log lost IRQs Philippe Mathieu-Daudé
@ 2020-05-12 6:53 ` Philippe Mathieu-Daudé
2020-05-14 20:20 ` John Snow
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-12 6:53 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, qemu-block
ping?
On 5/4/20 11:48 AM, Philippe Mathieu-Daudé wrote:
> One might find interesting to look at AHCI IRQs.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ide/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 13d91e109a..fc82cbd5f1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
>
> static void ahci_irq_set(void *opaque, int n, int level)
> {
> + qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
> }
>
> static const IDEDMAOps ahci_dma_ops = {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/ide/ahci: Log lost IRQs
2020-05-04 9:48 [PATCH] hw/ide/ahci: Log lost IRQs Philippe Mathieu-Daudé
2020-05-12 6:53 ` Philippe Mathieu-Daudé
@ 2020-05-14 20:20 ` John Snow
2020-05-15 10:05 ` Kevin Wolf
1 sibling, 1 reply; 4+ messages in thread
From: John Snow @ 2020-05-14 20:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-block
On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> One might find interesting to look at AHCI IRQs.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ide/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 13d91e109a..fc82cbd5f1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
>
> static void ahci_irq_set(void *opaque, int n, int level)
> {
> + qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
> }
>
> static const IDEDMAOps ahci_dma_ops = {
>
Reviewed-by: John Snow <jsnow@redhat.com>
Sorry, just drowning in backlog. Thanks for the ping on IRC.
Acked-by: John Snow <jsnow@redhat.com>
^ Feel free to take through trivial tree.
--js
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hw/ide/ahci: Log lost IRQs
2020-05-14 20:20 ` John Snow
@ 2020-05-15 10:05 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2020-05-15 10:05 UTC (permalink / raw)
To: John Snow; +Cc: Philippe Mathieu-Daudé, qemu-block, qemu-devel
Am 14.05.2020 um 22:20 hat John Snow geschrieben:
>
>
> On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> > One might find interesting to look at AHCI IRQs.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > hw/ide/ahci.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> > index 13d91e109a..fc82cbd5f1 100644
> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
> >
> > static void ahci_irq_set(void *opaque, int n, int level)
> > {
> > + qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
> > }
> >
> > static const IDEDMAOps ahci_dma_ops = {
> >
>
> Reviewed-by: John Snow <jsnow@redhat.com>
>
> Sorry, just drowning in backlog. Thanks for the ping on IRC.
>
> Acked-by: John Snow <jsnow@redhat.com>
>
> ^ Feel free to take through trivial tree.
I'll take it through the block tree then.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-04 9:48 [PATCH] hw/ide/ahci: Log lost IRQs Philippe Mathieu-Daudé
2020-05-12 6:53 ` Philippe Mathieu-Daudé
2020-05-14 20:20 ` John Snow
2020-05-15 10:05 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).