From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PATCH v2 13/13] [RFC] audio: try use onboard audiodev for pcspk
Date: Fri, 15 May 2020 16:35:28 +0200 [thread overview]
Message-ID: <20200515143528.13591-14-kraxel@redhat.com> (raw)
In-Reply-To: <20200515143528.13591-1-kraxel@redhat.com>
New naming convention: Use "onboard" audiodev for onboard audio
devices, using "-audiodev pa,id=onboard" for example.
This patchs implements it for pcspk, it will try to use "onboard" by
default. Setting another name using "-global pcspk.audiodev=<name>"
continues to work.
If we want go this route we should do the same for other onboard
audio devices too (arm boards, ...).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/audio/pcspk.c | 3 +++
docs/system/deprecated.rst | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index ab290e686783..9a08e9d8e05b 100644
--- a/hw/audio/pcspk.c
+++ b/hw/audio/pcspk.c
@@ -190,6 +190,9 @@ static void pcspk_realizefn(DeviceState *dev, Error **errp)
isa_register_ioport(isadev, &s->ioport, s->iobase);
+ if (!s->card.state) {
+ s->card.state = audio_state_by_name("onboard");
+ }
if (s->card.state) {
pcspk_audio_init(s);
}
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 7de1045b7e27..34312fc0a963 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -94,8 +94,8 @@ Creating sound card devices using ``-soundhw`` (since 5.1)
Sound card devices should be created using ``-device`` instead. The
names are the same for most devices. The exceptions are ``hda`` which
needs two devices (``-device intel-hda --device hda-duplex``) and
-``pcspk`` which can be activated using ``-global
-pcspk.audiodev=<name>``.
+``pcspk`` which can be activated by creating an audiodev named
+``onboard``.
``-mon ...,control=readline,pretty=on|off`` (since 4.1)
'''''''''''''''''''''''''''''''''''''''''''''''''''''''
--
2.18.4
next prev parent reply other threads:[~2020-05-15 14:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:35 [PATCH v2 00/13] audio: deprecate -soundhw Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 01/13] stubs: add isa_create_simple Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 02/13] stubs: add pci_create_simple Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 03/13] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 04/13] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 05/13] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 06/13] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 07/13] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 08/13] audio: deprecate -soundhw gus Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 09/13] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 10/13] audio: deprecate -soundhw hda Gerd Hoffmann
2020-05-15 14:35 ` [PATCH v2 11/13] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-05-15 15:08 ` Ján Tomko
2020-05-18 10:16 ` Gerd Hoffmann
2020-05-18 10:26 ` Daniel P. Berrangé
2020-05-18 10:55 ` Ján Tomko
2020-05-18 11:24 ` Gerd Hoffmann
2020-05-18 12:59 ` Gerd Hoffmann
2020-05-18 13:16 ` Markus Armbruster
2020-05-18 13:27 ` Gerd Hoffmann
2020-05-21 14:08 ` Paolo Bonzini
2020-05-15 14:35 ` [PATCH v2 12/13] audio: add soundhw deprecation notice Gerd Hoffmann
2020-05-15 14:35 ` Gerd Hoffmann [this message]
2020-05-18 10:42 ` [PATCH v2 00/13] audio: deprecate -soundhw Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515143528.13591-14-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).