From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v6 14/16] acpi: drop serial/parallel enable bits from dsdt
Date: Fri, 15 May 2020 17:04:19 +0200 [thread overview]
Message-ID: <20200515150421.25479-15-kraxel@redhat.com> (raw)
In-Reply-To: <20200515150421.25479-1-kraxel@redhat.com>
The _STA methods for COM+LPT used to reference them,
but that isn't the case any more.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 1922868f3401..765409a90eb6 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1437,15 +1437,6 @@ static void build_q35_isa_bridge(Aml *table)
aml_append(field, aml_named_field("LPTD", 2));
aml_append(dev, field);
- aml_append(dev, aml_operation_region("LPCE", AML_PCI_CONFIG,
- aml_int(0x82), 0x02));
- /* enable bits */
- field = aml_field("LPCE", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE);
- aml_append(field, aml_named_field("CAEN", 1));
- aml_append(field, aml_named_field("CBEN", 1));
- aml_append(field, aml_named_field("LPEN", 1));
- aml_append(dev, field);
-
aml_append(scope, dev);
aml_append(table, scope);
}
@@ -1469,7 +1460,6 @@ static void build_piix4_isa_bridge(Aml *table)
{
Aml *dev;
Aml *scope;
- Aml *field;
scope = aml_scope("_SB.PCI0");
dev = aml_device("ISA");
@@ -1478,19 +1468,6 @@ static void build_piix4_isa_bridge(Aml *table)
/* PIIX PCI to ISA irq remapping */
aml_append(dev, aml_operation_region("P40C", AML_PCI_CONFIG,
aml_int(0x60), 0x04));
- /* enable bits */
- field = aml_field("^PX13.P13C", AML_ANY_ACC, AML_NOLOCK, AML_PRESERVE);
- /* Offset(0x5f),, 7, */
- aml_append(field, aml_reserved_field(0x2f8));
- aml_append(field, aml_reserved_field(7));
- aml_append(field, aml_named_field("LPEN", 1));
- /* Offset(0x67),, 3, */
- aml_append(field, aml_reserved_field(0x38));
- aml_append(field, aml_reserved_field(3));
- aml_append(field, aml_named_field("CAEN", 1));
- aml_append(field, aml_reserved_field(3));
- aml_append(field, aml_named_field("CBEN", 1));
- aml_append(dev, field);
aml_append(scope, dev);
aml_append(table, scope);
--
2.18.4
next prev parent reply other threads:[~2020-05-15 15:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 15:04 [PATCH v6 00/16] acpi: i386 tweaks Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 01/16] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 02/16] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 03/16] acpi: rtc: use a single crs range Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 04/16] acpi: serial: don't use _STA method Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 05/16] acpi: move aml builder code for serial device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 06/16] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 07/16] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 08/16] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-06-09 14:28 ` Michael S. Tsirkin
2020-05-15 15:04 ` [PATCH v6 09/16] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 10/16] floppy: move cmos_get_fd_drive_type() from pc Gerd Hoffmann
2020-05-19 14:51 ` Philippe Mathieu-Daudé
2020-05-19 23:09 ` John Snow
2020-05-20 8:43 ` Gerd Hoffmann
2020-05-20 10:29 ` Michael S. Tsirkin
2020-05-15 15:04 ` [PATCH v6 11/16] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 12/16] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-05-15 15:04 ` [PATCH v6 13/16] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-05-15 15:04 ` Gerd Hoffmann [this message]
2020-05-15 15:04 ` [PATCH v6 15/16] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-05-20 10:20 ` Igor Mammedow
2020-05-15 15:04 ` [PATCH v6 16/16] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-05-16 0:23 ` [PATCH v6 00/16] acpi: i386 tweaks no-reply
2020-05-16 8:29 ` no-reply
2020-05-16 12:51 ` no-reply
2020-06-08 13:22 ` Gerd Hoffmann
2020-06-08 13:24 ` Michael S. Tsirkin
2020-06-09 14:29 ` Michael S. Tsirkin
2020-06-10 9:40 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515150421.25479-15-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).