From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A97FC433E0 for ; Fri, 15 May 2020 16:49:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9812207F9 for ; Fri, 15 May 2020 16:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P9IrdxPZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9812207F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZdW7-0002Rc-Vz for qemu-devel@archiver.kernel.org; Fri, 15 May 2020 12:49:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZdUc-0000UJ-DL for qemu-devel@nongnu.org; Fri, 15 May 2020 12:47:26 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:35456 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jZdUb-0007bU-FS for qemu-devel@nongnu.org; Fri, 15 May 2020 12:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589561244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+vDoS6rtXmiEsFGa8fr+cErcnWf910dF9m0oUPGIPlo=; b=P9IrdxPZrMUBNu7gs2673I2DlgJTWeL0tw42iPOIo58+mYEpG9aSyNkTbNSutd/AOEp8nX gA9CJ0s+azGTC8QL4AZ83uSNU105I86I3QLylhuT0UlyyVhRdegD5wWsQIit0WPEmuiAoj hzRy1e8W8QpaG9ocHMlNs6pXbFqnb1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-EOXWEmFjMLOHXnoe0r3qXA-1; Fri, 15 May 2020 12:47:23 -0400 X-MC-Unique: EOXWEmFjMLOHXnoe0r3qXA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D5807107AFC6; Fri, 15 May 2020 16:47:21 +0000 (UTC) Received: from work-vm (ovpn-114-149.ams2.redhat.com [10.36.114.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED72C5D9F1; Fri, 15 May 2020 16:47:02 +0000 (UTC) Date: Fri, 15 May 2020 17:46:59 +0100 From: "Dr. David Alan Gilbert" To: David Hildenbrand Subject: Re: [PATCH v1 16/17] virtio-mem: Allow notifiers for size changes Message-ID: <20200515164659.GK2954@work-vm> References: <20200506094948.76388-1-david@redhat.com> <20200506094948.76388-17-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506094948.76388-17-david@redhat.com> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Received-SPF: pass client-ip=205.139.110.61; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/15 00:07:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_HK_NAME_DR=0.01 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm@vger.kernel.org, "Michael S . Tsirkin" , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * David Hildenbrand (david@redhat.com) wrote: > We want to send qapi events in case the size of a virtio-mem device > changes. This allows upper layers to always know how much memory is > actually currently consumed via a virtio-mem device. > > Unfortuantely, we have to report the id of our proxy device. Let's provide > an easy way for our proxy device to register, so it can send the qapi > events. Piggy-backing on the notifier infrastructure (although we'll > only ever have one notifier registered) seems to be an easy way. > > Cc: "Michael S. Tsirkin" > Cc: "Dr. David Alan Gilbert" > Cc: Igor Mammedov > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > hw/virtio/virtio-mem.c | 21 ++++++++++++++++++++- > include/hw/virtio/virtio-mem.h | 5 +++++ > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c > index e25b2c74f2..88a99a0d90 100644 > --- a/hw/virtio/virtio-mem.c > +++ b/hw/virtio/virtio-mem.c > @@ -198,6 +198,7 @@ static int virtio_mem_state_change_request(VirtIOMEM *vmem, uint64_t gpa, > } else { > vmem->size -= size; > } > + notifier_list_notify(&vmem->size_change_notifiers, &vmem->size); > return VIRTIO_MEM_RESP_ACK; > } > > @@ -253,7 +254,10 @@ static int virtio_mem_unplug_all(VirtIOMEM *vmem) > return -EBUSY; > } > bitmap_clear(vmem->bitmap, 0, vmem->bitmap_size); > - vmem->size = 0; > + if (vmem->size != 0) { > + vmem->size = 0; > + notifier_list_notify(&vmem->size_change_notifiers, &vmem->size); > + } > > virtio_mem_resize_usable_region(vmem, vmem->requested_size, true); > return 0; > @@ -594,6 +598,18 @@ static MemoryRegion *virtio_mem_get_memory_region(VirtIOMEM *vmem, Error **errp) > return &vmem->memdev->mr; > } > > +static void virtio_mem_add_size_change_notifier(VirtIOMEM *vmem, > + Notifier *notifier) > +{ > + notifier_list_add(&vmem->size_change_notifiers, notifier); > +} > + > +static void virtio_mem_remove_size_change_notifier(VirtIOMEM *vmem, > + Notifier *notifier) > +{ > + notifier_remove(notifier); > +} > + > static void virtio_mem_get_size(Object *obj, Visitor *v, const char *name, > void *opaque, Error **errp) > { > @@ -705,6 +721,7 @@ static void virtio_mem_instance_init(Object *obj) > VirtIOMEM *vmem = VIRTIO_MEM(obj); > > vmem->block_size = VIRTIO_MEM_MIN_BLOCK_SIZE; > + notifier_list_init(&vmem->size_change_notifiers); > > object_property_add(obj, VIRTIO_MEM_SIZE_PROP, "size", virtio_mem_get_size, > NULL, NULL, NULL, &error_abort); > @@ -743,6 +760,8 @@ static void virtio_mem_class_init(ObjectClass *klass, void *data) > > vmc->fill_device_info = virtio_mem_fill_device_info; > vmc->get_memory_region = virtio_mem_get_memory_region; > + vmc->add_size_change_notifier = virtio_mem_add_size_change_notifier; > + vmc->remove_size_change_notifier = virtio_mem_remove_size_change_notifier; > } > > static const TypeInfo virtio_mem_info = { > diff --git a/include/hw/virtio/virtio-mem.h b/include/hw/virtio/virtio-mem.h > index 27158cb611..5820b5c23e 100644 > --- a/include/hw/virtio/virtio-mem.h > +++ b/include/hw/virtio/virtio-mem.h > @@ -66,6 +66,9 @@ typedef struct VirtIOMEM { > /* block size and alignment */ > uint32_t block_size; > uint32_t migration_block_size; > + > + /* notifiers to notify when "size" changes */ > + NotifierList size_change_notifiers; > } VirtIOMEM; > > typedef struct VirtIOMEMClass { > @@ -75,6 +78,8 @@ typedef struct VirtIOMEMClass { > /* public */ > void (*fill_device_info)(const VirtIOMEM *vmen, VirtioMEMDeviceInfo *vi); > MemoryRegion *(*get_memory_region)(VirtIOMEM *vmem, Error **errp); > + void (*add_size_change_notifier)(VirtIOMEM *vmem, Notifier *notifier); > + void (*remove_size_change_notifier)(VirtIOMEM *vmem, Notifier *notifier); > } VirtIOMEMClass; > > #endif > -- > 2.25.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK