qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com, den@openvz.org
Subject: [PATCH v4 1/9] iotests/277: use dot slash for nbd-fault-injector.py running
Date: Sat, 16 May 2020 00:14:57 +0300	[thread overview]
Message-ID: <20200515211505.3042-2-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200515211505.3042-1-vsementsov@virtuozzo.com>

If you run './check 277', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds nbd-fault-injector.py
on PATH.  But if you run './277' directly, there is nothing to adjust
PATH, and if '.' is not already on your PATH by other means, the test
fails because the executable is not found.  Adjust how we invoke the
helper executable to avoid needing a PATH search in the first place.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 tests/qemu-iotests/277 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/277 b/tests/qemu-iotests/277
index d34f87021f..a39ce2d873 100755
--- a/tests/qemu-iotests/277
+++ b/tests/qemu-iotests/277
@@ -42,7 +42,7 @@ def make_conf_file(event):
 def start_server_NBD(event):
     make_conf_file(event)
 
-    srv = subprocess.Popen(['nbd-fault-injector.py', '--classic-negotiation',
+    srv = subprocess.Popen(['./nbd-fault-injector.py', '--classic-negotiation',
                            nbd_sock, conf_file], stdout=subprocess.PIPE,
                            stderr=subprocess.STDOUT, universal_newlines=True)
     line = srv.stdout.readline()
-- 
2.21.0



  reply	other threads:[~2020-05-15 21:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 21:14 [PATCH v4 0/9] Rework iotests/check Vladimir Sementsov-Ogievskiy
2020-05-15 21:14 ` Vladimir Sementsov-Ogievskiy [this message]
2020-05-15 21:14 ` [PATCH v4 2/9] iotests: fix some whitespaces in test output files Vladimir Sementsov-Ogievskiy
2020-05-15 21:14 ` [PATCH v4 3/9] iotests/283: make executable Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 4/9] iotests: define group in each iotest Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 5/9] iotests: add findtests.py Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 6/9] iotests: add testenv.py Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 7/9] iotests: add testrunner.py Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 8/9] iotests: rewrite check into python Vladimir Sementsov-Ogievskiy
2020-05-15 21:15 ` [PATCH v4 9/9] iotests: rename and move 169 and 199 tests Vladimir Sementsov-Ogievskiy
2020-05-18 16:12   ` Thomas Huth
2020-05-18 17:33     ` Vladimir Sementsov-Ogievskiy
2020-05-19  9:07     ` Kevin Wolf
2020-05-19 11:32       ` Vladimir Sementsov-Ogievskiy
2020-05-19 11:41         ` Kevin Wolf
2020-05-21 18:32           ` John Snow
2020-05-27 18:50             ` Vladimir Sementsov-Ogievskiy
2020-05-29 19:37               ` John Snow
2020-06-20 15:38 ` [PATCH v4 0/9] Rework iotests/check Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515211505.3042-2-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).