qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: [PATCH v2 05/11] ui/gtk: remove unused variable ignore_keys
Date: Sat, 16 May 2020 09:20:08 +0200	[thread overview]
Message-ID: <20200516072014.7766-5-vr_qemu@t-online.de> (raw)
In-Reply-To: <bea1a22a-1fb4-b49b-c089-e0a5c5cf55cd@t-online.de>

Since the removal of GTK2 code in commit 89d85cde75 the code
around ignore_keys is unused. See commit 1a01716a30 "gtk: Avoid
accel key leakage into guest on console switch" why it was only
needed for GTK2.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 ui/gtk.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index 0e9503a0d1..354dd90e18 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -168,8 +168,6 @@ struct GtkDisplayState {
 
     bool external_pause_update;
 
-    bool ignore_keys;
-
     DisplayOptions *opts;
 };
 
@@ -1095,14 +1093,8 @@ static gboolean gd_text_key_down(GtkWidget *widget,
 static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
 {
     VirtualConsole *vc = opaque;
-    GtkDisplayState *s = vc->s;
     int qcode;
 
-    if (s->ignore_keys) {
-        s->ignore_keys = (key->type == GDK_KEY_PRESS);
-        return TRUE;
-    }
-
 #ifdef WIN32
     /* on windows, we ought to ignore the reserved key event? */
     if (key->hardware_keycode == 0xff)
@@ -1204,7 +1196,6 @@ static void gd_menu_switch_vc(GtkMenuItem *item, void *opaque)
         gtk_notebook_set_current_page(nb, page);
         gtk_widget_grab_focus(vc->focus);
     }
-    s->ignore_keys = false;
 }
 
 static void gd_accel_switch_vc(void *opaque)
-- 
2.26.1



  parent reply	other threads:[~2020-05-16  7:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  7:18 [PATCH v2 00/11] Patches for ui/gtk and ui/sdl Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 01/11] ui/win32-kbd-hook: handle AltGr in a hook procedure Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 02/11] ui/gtk: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19  6:59   ` Gerd Hoffmann
2020-05-16  7:20 ` [PATCH v2 03/11] ui/gkt: release all keys on grab-broken-event Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 04/11] ui/gtk: remove unused code Volker Rümelin
2020-05-16  7:20 ` Volker Rümelin [this message]
2020-05-16  7:20 ` [PATCH v2 06/11] ui/sdl2: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19  7:03   ` Gerd Hoffmann
2020-05-16  7:20 ` [PATCH v2 07/11] ui/sdl2: start in full screen with grab enabled Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 08/11] ui/sdl2-input: use trace-events to debug key events Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 09/11] ui/gtk: don't pass on win keys without keyboard grab Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 10/11] ui/gtk: use native keyboard scancodes on Windows Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 11/11] ui: increase min required GTK version to 3.22.0 Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516072014.7766-5-vr_qemu@t-online.de \
    --to=vr_qemu@t-online.de \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).