qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: [PATCH v2 07/11] ui/sdl2: start in full screen with grab enabled
Date: Sat, 16 May 2020 09:20:10 +0200	[thread overview]
Message-ID: <20200516072014.7766-7-vr_qemu@t-online.de> (raw)
In-Reply-To: <bea1a22a-1fb4-b49b-c089-e0a5c5cf55cd@t-online.de>

QEMU with SDL 1.2 display used to enable keyboard and mouse grab-
bing when started in full screen. The SDL 2.0 code tries to do
the same but fails to enable grabbing because sdl_grab_start(0)
returns early. To do it's work the sdl_grab_start() function
needs a pointer to a sdl2_console structure.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
 ui/sdl2.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/ui/sdl2.c b/ui/sdl2.c
index 79c1ea29d2..b23a8f0a8e 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -881,17 +881,16 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
         SDL_SetWindowIcon(sdl2_console[0].real_window, icon);
     }
 
-    gui_grab = 0;
-    if (gui_fullscreen) {
-        sdl_grab_start(0);
-    }
-
     mouse_mode_notifier.notify = sdl_mouse_mode_change;
     qemu_add_mouse_mode_change_notifier(&mouse_mode_notifier);
 
     sdl_cursor_hidden = SDL_CreateCursor(&data, &data, 8, 1, 0, 0);
     sdl_cursor_normal = SDL_GetCursor();
 
+    if (gui_fullscreen) {
+        sdl_grab_start(&sdl2_console[0]);
+    }
+
     atexit(sdl_cleanup);
 }
 
-- 
2.26.1



  parent reply	other threads:[~2020-05-16  7:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  7:18 [PATCH v2 00/11] Patches for ui/gtk and ui/sdl Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 01/11] ui/win32-kbd-hook: handle AltGr in a hook procedure Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 02/11] ui/gtk: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19  6:59   ` Gerd Hoffmann
2020-05-16  7:20 ` [PATCH v2 03/11] ui/gkt: release all keys on grab-broken-event Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 04/11] ui/gtk: remove unused code Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 05/11] ui/gtk: remove unused variable ignore_keys Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 06/11] ui/sdl2: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19  7:03   ` Gerd Hoffmann
2020-05-16  7:20 ` Volker Rümelin [this message]
2020-05-16  7:20 ` [PATCH v2 08/11] ui/sdl2-input: use trace-events to debug key events Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 09/11] ui/gtk: don't pass on win keys without keyboard grab Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 10/11] ui/gtk: use native keyboard scancodes on Windows Volker Rümelin
2020-05-16  7:20 ` [PATCH v2 11/11] ui: increase min required GTK version to 3.22.0 Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516072014.7766-7-vr_qemu@t-online.de \
    --to=vr_qemu@t-online.de \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).