From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: [PATCH v2 09/11] ui/gtk: don't pass on win keys without keyboard grab
Date: Sat, 16 May 2020 09:20:12 +0200 [thread overview]
Message-ID: <20200516072014.7766-9-vr_qemu@t-online.de> (raw)
In-Reply-To: <bea1a22a-1fb4-b49b-c089-e0a5c5cf55cd@t-online.de>
Without keyboard grab Windows currently handles the two win keys
and the key events are also sent to the guest. This is undesir-
able. Only one program should handle key events. This patch ap-
plies commit c68f74b02e "win32: do not handle win keys when the
keyboard is not grabbed" from project spice-gtk to ui/gtk.c to
fix this problem.
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
ui/gtk.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 354dd90e18..1d51e14bb5 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1095,10 +1095,17 @@ static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
VirtualConsole *vc = opaque;
int qcode;
-#ifdef WIN32
+#ifdef G_OS_WIN32
/* on windows, we ought to ignore the reserved key event? */
if (key->hardware_keycode == 0xff)
return false;
+
+ if (!vc->s->kbd_owner) {
+ if (key->hardware_keycode == VK_LWIN ||
+ key->hardware_keycode == VK_RWIN) {
+ return FALSE;
+ }
+ }
#endif
if (key->keyval == GDK_KEY_Pause
--
2.26.1
next prev parent reply other threads:[~2020-05-16 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 7:18 [PATCH v2 00/11] Patches for ui/gtk and ui/sdl Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 01/11] ui/win32-kbd-hook: handle AltGr in a hook procedure Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 02/11] ui/gtk: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19 6:59 ` Gerd Hoffmann
2020-05-16 7:20 ` [PATCH v2 03/11] ui/gkt: release all keys on grab-broken-event Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 04/11] ui/gtk: remove unused code Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 05/11] ui/gtk: remove unused variable ignore_keys Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 06/11] ui/sdl2: fix handling of AltGr key on Windows Volker Rümelin
2020-05-19 7:03 ` Gerd Hoffmann
2020-05-16 7:20 ` [PATCH v2 07/11] ui/sdl2: start in full screen with grab enabled Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 08/11] ui/sdl2-input: use trace-events to debug key events Volker Rümelin
2020-05-16 7:20 ` Volker Rümelin [this message]
2020-05-16 7:20 ` [PATCH v2 10/11] ui/gtk: use native keyboard scancodes on Windows Volker Rümelin
2020-05-16 7:20 ` [PATCH v2 11/11] ui: increase min required GTK version to 3.22.0 Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516072014.7766-9-vr_qemu@t-online.de \
--to=vr_qemu@t-online.de \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).