* [PATCH 0/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
@ 2020-05-15 20:30 Dan Robertson
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
0 siblings, 1 reply; 6+ messages in thread
From: Dan Robertson @ 2020-05-15 20:30 UTC (permalink / raw)
To: Greg Kurz, Christian Schoenebeck; +Cc: Dan Robertson, qemu-devel
When compliling qemu with `--enable-virtfs` and musl libc, XATTR_SIZE_MAX
is undeclared in v9fs_xattrcreate. Things compile fine with glibc as
linux/limits.h is indirectly included via dirent.h.
Dan Robertson (1):
9pfs: include linux/limits.h for XATTR_SIZE_MAX
hw/9pfs/9p.c | 1 +
1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
2020-05-15 20:30 [PATCH 0/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX Dan Robertson
@ 2020-05-15 20:30 ` Dan Robertson
2020-05-16 5:22 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dan Robertson @ 2020-05-15 20:30 UTC (permalink / raw)
To: Greg Kurz, Christian Schoenebeck; +Cc: Dan Robertson, qemu-devel
linux/limits.h should be included for the XATTR_SIZE_MAX definition used
by v9fs_xattrcreate.
Signed-off-by: Dan Robertson <dan@dlrobertson.com>
---
hw/9pfs/9p.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index a2a14b5979..68c2df7333 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -28,6 +28,7 @@
#include "sysemu/qtest.h"
#include "qemu/xxhash.h"
#include <math.h>
+#include <linux/limits.h>
int open_fd_hw;
int total_open_fd;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
@ 2020-05-16 5:22 ` Philippe Mathieu-Daudé
2020-05-16 10:28 ` Christian Schoenebeck
2020-05-16 11:30 ` Greg Kurz
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-16 5:22 UTC (permalink / raw)
To: Dan Robertson, Greg Kurz, Christian Schoenebeck; +Cc: qemu-devel
On 5/15/20 10:30 PM, Dan Robertson wrote:
> linux/limits.h should be included for the XATTR_SIZE_MAX definition used
Maybe rewrite as <linux/limits.h> in subject & description (maintainer
could do it for you).
> by v9fs_xattrcreate.
>
Fixes: 3b79ef2cf48
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> ---
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index a2a14b5979..68c2df7333 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -28,6 +28,7 @@
> #include "sysemu/qtest.h"
> #include "qemu/xxhash.h"
> #include <math.h>
> +#include <linux/limits.h>
>
> int open_fd_hw;
> int total_open_fd;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
2020-05-16 5:22 ` Philippe Mathieu-Daudé
@ 2020-05-16 10:28 ` Christian Schoenebeck
2020-05-16 11:30 ` Greg Kurz
2 siblings, 0 replies; 6+ messages in thread
From: Christian Schoenebeck @ 2020-05-16 10:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Dan Robertson, Greg Kurz, Philippe Mathieu-Daudé
On Freitag, 15. Mai 2020 22:30:15 CEST Dan Robertson wrote:
> linux/limits.h should be included for the XATTR_SIZE_MAX definition used
> by v9fs_xattrcreate.
>
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> ---
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index a2a14b5979..68c2df7333 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -28,6 +28,7 @@
> #include "sysemu/qtest.h"
> #include "qemu/xxhash.h"
> #include <math.h>
> +#include <linux/limits.h>
>
> int open_fd_hw;
> int total_open_fd;
Usually I would say that should be wrapped in some OS conditional way, but as
usage of XATTR_SIZE_MAX is currently not in 9p code either, it's Ok for now.
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Best regards,
Christian Schoenebeck
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
2020-05-16 5:22 ` Philippe Mathieu-Daudé
2020-05-16 10:28 ` Christian Schoenebeck
@ 2020-05-16 11:30 ` Greg Kurz
2020-05-16 14:41 ` Dan Robertson
2 siblings, 1 reply; 6+ messages in thread
From: Greg Kurz @ 2020-05-16 11:30 UTC (permalink / raw)
To: Dan Robertson
Cc: Philippe Mathieu-Daudé, Christian Schoenebeck, qemu-devel
On Fri, 15 May 2020 20:30:15 +0000
Dan Robertson <dan@dlrobertson.com> wrote:
> linux/limits.h should be included for the XATTR_SIZE_MAX definition used
> by v9fs_xattrcreate.
>
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> ---
Applied to 9p-next with R-b and Fixes tags, thanks.
> hw/9pfs/9p.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index a2a14b5979..68c2df7333 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -28,6 +28,7 @@
> #include "sysemu/qtest.h"
> #include "qemu/xxhash.h"
> #include <math.h>
> +#include <linux/limits.h>
>
> int open_fd_hw;
> int total_open_fd;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
2020-05-16 11:30 ` Greg Kurz
@ 2020-05-16 14:41 ` Dan Robertson
0 siblings, 0 replies; 6+ messages in thread
From: Dan Robertson @ 2020-05-16 14:41 UTC (permalink / raw)
To: Greg Kurz; +Cc: Philippe Mathieu-Daudé, Christian Schoenebeck, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 172 bytes --]
On Sat, May 16, 2020 at 01:30:23PM +0200, Greg Kurz wrote:
> Applied to 9p-next with R-b and Fixes tags, thanks.
Great! Thanks for the feedback everyone.
Cheers,
- Dan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-16 15:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-15 20:30 [PATCH 0/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX Dan Robertson
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
2020-05-16 5:22 ` Philippe Mathieu-Daudé
2020-05-16 10:28 ` Christian Schoenebeck
2020-05-16 11:30 ` Greg Kurz
2020-05-16 14:41 ` Dan Robertson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).