qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: qemu-devel@nongnu.org
Cc: aleksandar.rikalo@rt-rk.com,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH v3 17/18] hw/mips: Add some logging for bad register offset cases
Date: Sat, 16 May 2020 19:45:47 +0200	[thread overview]
Message-ID: <20200516174548.7631-18-aleksandar.qemu.devel@gmail.com> (raw)
In-Reply-To: <20200516174548.7631-1-aleksandar.qemu.devel@gmail.com>

Log the cases where a guest attempts read or write using bad
register offset.

Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
CC: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/mips/mips_malta.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index e4c4de1b4e..88869b828e 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -427,10 +427,9 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr addr,
         break;
 
     default:
-#if 0
-        printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n",
-               addr);
-#endif
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "malta_fpga_read: Bad register offset 0x"
+                      TARGET_FMT_lx "\n", addr);
         break;
     }
     return val;
@@ -515,10 +514,9 @@ static void malta_fpga_write(void *opaque, hwaddr addr,
         break;
 
     default:
-#if 0
-        printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n",
-               addr);
-#endif
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "malta_fpga_write: Bad register offset 0x"
+                      TARGET_FMT_lx "\n", addr);
         break;
     }
 }
-- 
2.20.1



  parent reply	other threads:[~2020-05-16 17:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 17:45 [PATCH v3 00/18] target/mips: FPU and other cleanups and improvements Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 01/18] target/mips: fpu: Demacro ADD.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 02/18] target/mips: fpu: Demacro SUB.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 03/18] target/mips: fpu: Demacro MUL.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 04/18] target/mips: fpu: Demacro DIV.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 05/18] target/mips: fpu: Remove now unused macro FLOAT_BINOP Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 06/18] target/mips: fpu: Demacro MADD.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 07/18] target/mips: fpu: Demacro MSUB.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 08/18] target/mips: fpu: Demacro NMADD.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 09/18] target/mips: fpu: Demacro NMSUB.<D|S|PS> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 10/18] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 11/18] target/mips: fpu: Demacro CLASS.<D|S> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 12/18] target/mips: fpu: Remove now unused FLOAT_CLASS macro Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 13/18] target/mips: fpu: Demacro RINT.<D|S> Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 14/18] target/mips: fpu: Remove now unused FLOAT_RINT macro Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 15/18] target/mips: fpu: Name better paired-single variables Aleksandar Markovic
2020-05-16 17:45 ` [PATCH v3 16/18] target/mips: fpu: Refactor conversion from ieee to mips exception flags Aleksandar Markovic
2020-05-16 17:45 ` Aleksandar Markovic [this message]
2020-05-16 18:54   ` [PATCH v3 17/18] hw/mips: Add some logging for bad register offset cases Philippe Mathieu-Daudé
2020-05-16 17:45 ` [PATCH v3 18/18] MAINTAINERS: Change Aleksandar Rikalo's email address Aleksandar Markovic
2020-05-16 18:55   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200516174548.7631-18-aleksandar.qemu.devel@gmail.com \
    --to=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).