From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C18BAC433DF for ; Mon, 18 May 2020 05:20:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87E8120715 for ; Mon, 18 May 2020 05:20:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bNtxR77m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87E8120715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaYCt-00082s-Ho for qemu-devel@archiver.kernel.org; Mon, 18 May 2020 01:20:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaYBs-0006EW-4P for qemu-devel@nongnu.org; Mon, 18 May 2020 01:19:52 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54522 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jaYBr-0007IT-2B for qemu-devel@nongnu.org; Mon, 18 May 2020 01:19:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589779189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bXECg6VhPKKPr6IKwLJ3K+f3rEK+su26Y48KCxlnGw4=; b=bNtxR77modDRhN7SY39N1UoJ18SVPi3/g99Q9bJGeBh9MUeQYhtAYNoGGuUE+MDh6XvPX5 DKeyfQP7zTudZ1AeeFwJoeK6cwmZI6vL/QgzyjaGk4UQg1hbAZ/quc9wjBHoIS1s3ltA5C jf2ZsyGS6Hnz1NZvnS03TyzhwY9R2vw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-8wf1kNiaMGmx01bF5u00ow-1; Mon, 18 May 2020 01:19:47 -0400 X-MC-Unique: 8wf1kNiaMGmx01bF5u00ow-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F24F1005512 for ; Mon, 18 May 2020 05:19:47 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E19363A0; Mon, 18 May 2020 05:19:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5DFDA11358BD; Mon, 18 May 2020 07:19:45 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH not-for-merge 1/5] qom: Instrument to detect missed realize Date: Mon, 18 May 2020 07:19:41 +0200 Message-Id: <20200518051945.8621-2-armbru@redhat.com> In-Reply-To: <20200518051945.8621-1-armbru@redhat.com> References: <20200518051945.8621-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 22:51:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, berrange@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Markus Armbruster --- qom/qom-hmp-cmds.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/qom/qom-hmp-cmds.c b/qom/qom-hmp-cmds.c index cd08233a4c..4a61ee1b8c 100644 --- a/qom/qom-hmp-cmds.c +++ b/qom/qom-hmp-cmds.c @@ -91,6 +91,17 @@ static void print_qom_composition(Monitor *mon, Object *obj, int indent) } else { name = object_get_canonical_path_component(obj); } + + DeviceState *dev = (DeviceState *)object_dynamic_cast(obj, TYPE_DEVICE); + DeviceClass *dc = (DeviceClass *)object_class_dynamic_cast(obj->class, TYPE_DEVICE); + if (dev && !dev->realized) { + monitor_printf(mon, "### unrealized: %s (%s)\n", + name, object_get_typename(obj)); + } + if (dev && dc->bus_type && !dev->parent_bus) { + monitor_printf(mon, "### no %s bus: %s (%s)\n", + dc->bus_type, name, object_get_typename(obj)); + } monitor_printf(mon, "%*s/%s (%s)\n", indent, "", name, object_get_typename(obj)); g_free(name); -- 2.21.1