qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: qemu-devel@nongnu.org
Cc: aleksandar.rikalo@syrmia.com, Jafar Abdi <cafer.abdi@gmail.com>,
	Thomas Huth <thuth@redhat.com>,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v5 01/22] hw/tpm: fix usage of bool in tpm-tis.c
Date: Mon, 18 May 2020 21:41:28 +0200	[thread overview]
Message-ID: <20200518194149.16281-2-aleksandar.qemu.devel@gmail.com> (raw)
In-Reply-To: <20200518194149.16281-1-aleksandar.qemu.devel@gmail.com>

From: Jafar Abdi <cafer.abdi@gmail.com>

Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.

FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).

Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 hw/tpm/tpm_tis_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/tpm/tpm_tis_common.c b/hw/tpm/tpm_tis_common.c
index 9ce64d4836..1af4bce139 100644
--- a/hw/tpm/tpm_tis_common.c
+++ b/hw/tpm/tpm_tis_common.c
@@ -536,7 +536,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
             while ((TPM_TIS_IS_VALID_LOCTY(s->active_locty) &&
                     locty > s->active_locty) ||
                     !TPM_TIS_IS_VALID_LOCTY(s->active_locty)) {
-                bool higher_seize = FALSE;
+                bool higher_seize = false;
 
                 /* already a pending SEIZE ? */
                 if ((s->loc[locty].access & TPM_TIS_ACCESS_SEIZE)) {
@@ -546,7 +546,7 @@ static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
                 /* check for ongoing seize by a higher locality */
                 for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES; l++) {
                     if ((s->loc[l].access & TPM_TIS_ACCESS_SEIZE)) {
-                        higher_seize = TRUE;
+                        higher_seize = true;
                         break;
                     }
                 }
-- 
2.20.1



  reply	other threads:[~2020-05-18 19:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 19:41 [PATCH v5 00/22] target/mips: MSA, FPU and other cleanups and improvements Aleksandar Markovic
2020-05-18 19:41 ` Aleksandar Markovic [this message]
2020-05-18 19:49   ` [PATCH v5 01/22] hw/tpm: fix usage of bool in tpm-tis.c Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 02/22] target/mips: fpu: Demacro ADD.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 03/22] target/mips: fpu: Demacro SUB.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 04/22] target/mips: fpu: Demacro MUL.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 05/22] target/mips: fpu: Demacro DIV.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 06/22] target/mips: fpu: Remove now unused macro FLOAT_BINOP Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 07/22] target/mips: fpu: Demacro MADD.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 08/22] target/mips: fpu: Demacro MSUB.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 09/22] target/mips: fpu: Demacro NMADD.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 10/22] target/mips: fpu: Demacro NMSUB.<D|S|PS> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 11/22] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 12/22] target/mips: fpu: Demacro CLASS.<D|S> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 13/22] target/mips: fpu: Remove now unused FLOAT_CLASS macro Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 14/22] target/mips: fpu: Demacro RINT.<D|S> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 15/22] target/mips: fpu: Remove now unused FLOAT_RINT macro Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 16/22] target/mips: fpu: Name better paired-single variables Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 17/22] target/mips: fpu: Refactor conversion from ieee to mips exception flags Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 18/22] MAINTAINERS: Change Aleksandar Rikalo's email address Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 19/22] target/mips: msa: Split helpers for MADDV.<B|H|W|D> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 20/22] target/mips: msa: Split helpers for MSUBV.<B|H|W|D> Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 21/22] hw/mips: Add some logging for bad register offset cases Aleksandar Markovic
2020-05-18 19:41 ` [PATCH v5 22/22] hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200518194149.16281-2-aleksandar.qemu.devel@gmail.com \
    --to=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=cafer.abdi@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).