qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [RISU v2 00/17] risu cleanups and improvements
Date: Mon, 18 May 2020 19:53:38 -0700	[thread overview]
Message-ID: <20200519025355.4420-1-richard.henderson@linaro.org> (raw)

This patch set does alter the format of the trace files, and thus
means we'll have to re-generate these.  However, the space saved
for sve trace files is significant, so I consider it worthwhile.

In addition, the new --dump option allows one to inspect the
contents of the trace file.

Version 2 adds a number of patches that clean up the whole
reporting of errors thing.  This allows us to give sensible
output when things go awry.

If using old trace files with the new risu, you get

mismatch header after 1 checkpoints
header mismatch detail (master : apprentice):
  magic: 000000fc vs 52695375

If for somehow you use different risu for master and apprentice
on sockets, you get

i/o error after 1 checkpoints

Which is less helpful, but since the master has not written
enough data to the socket, the apprentice notices and reports
the i/o error before having a look at the header contents.


r~


Richard Henderson (17):
  Use bool for tracing variables
  Unify master_fd and apprentice_fd to comm_fd
  Hoist trace file opening
  Adjust tracefile open for write
  Use EXIT_FAILURE, EXIT_SUCCESS
  Make some risu.c symbols static
  Add enum RisuOp
  Add enum RisuResult
  Unify i/o functions and use RisuResult
  Pass non-OK result back through siglongjmp
  Always write for --master
  Simplify syncing with master
  Split RES_MISMATCH for registers and memory
  Add magic and size to the trace header
  Compute reginfo_size based on the reginfo
  aarch64: Reorg sve reginfo to save space
  Add --dump option to inspect trace files

 risu.h                 |  88 +++++----
 risu_reginfo_aarch64.h |  16 +-
 comms.c                |  34 ++--
 reginfo.c              | 274 ++++++++++++++++-----------
 risu.c                 | 409 +++++++++++++++++++++++++----------------
 risu_aarch64.c         |   6 +-
 risu_arm.c             |   6 +-
 risu_i386.c            |   4 +-
 risu_m68k.c            |   4 +-
 risu_ppc64.c           |   4 +-
 risu_reginfo_aarch64.c | 192 ++++++++++---------
 risu_reginfo_arm.c     |   6 +-
 risu_reginfo_i386.c    |   8 +-
 risu_reginfo_m68k.c    |   6 +-
 risu_reginfo_ppc64.c   |   6 +-
 15 files changed, 635 insertions(+), 428 deletions(-)

-- 
2.20.1



             reply	other threads:[~2020-05-19  2:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  2:53 Richard Henderson [this message]
2020-05-19  2:53 ` [RISU v2 01/17] Use bool for tracing variables Richard Henderson
2020-05-19 15:52   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 02/17] Unify master_fd and apprentice_fd to comm_fd Richard Henderson
2020-05-19 15:52   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 03/17] Hoist trace file opening Richard Henderson
2020-05-19 16:50   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 04/17] Adjust tracefile open for write Richard Henderson
2020-05-19 18:24   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 05/17] Use EXIT_FAILURE, EXIT_SUCCESS Richard Henderson
2020-05-19 18:24   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 06/17] Make some risu.c symbols static Richard Henderson
2020-05-19 18:25   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 07/17] Add enum RisuOp Richard Henderson
2020-05-19 18:39   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 08/17] Add enum RisuResult Richard Henderson
2020-05-19 19:06   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 09/17] Unify i/o functions and use RisuResult Richard Henderson
2020-05-20 15:50   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 10/17] Pass non-OK result back through siglongjmp Richard Henderson
2020-05-20 15:52   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 11/17] Always write for --master Richard Henderson
2020-05-20 16:12   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 12/17] Simplify syncing with master Richard Henderson
2020-05-20 16:14   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 13/17] Split RES_MISMATCH for registers and memory Richard Henderson
2020-05-20 16:25   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 14/17] Add magic and size to the trace header Richard Henderson
2020-05-19 21:16   ` Richard Henderson
2020-05-20 16:59     ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 15/17] Compute reginfo_size based on the reginfo Richard Henderson
2020-05-20 17:30   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 16/17] aarch64: Reorg sve reginfo to save space Richard Henderson
2020-05-20 18:43   ` Alex Bennée
2020-05-19  2:53 ` [RISU v2 17/17] Add --dump option to inspect trace files Richard Henderson
2020-05-20 17:49   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519025355.4420-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).