From: Kevin Wolf <kwolf@redhat.com>
To: Tao Xu <tao3.xu@intel.com>
Cc: John Snow <jsnow@redhat.com>, Zhang Chen <chen.zhang@intel.com>,
Alberto Garcia <berto@igalia.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: Migration with ``drive-mirror`` + NBD will let quorum qcow2 image become larger
Date: Tue, 19 May 2020 11:15:44 +0200 [thread overview]
Message-ID: <20200519091544.GD7652@linux.fritz.box> (raw)
In-Reply-To: <3b1bbe79-088c-2e65-178f-074ac0f72ec6@intel.com>
Am 19.05.2020 um 10:32 hat Tao Xu geschrieben:
> Hi,
>
> I am using ``drive-mirror`` + NBD for live storage migration. But I find
> that if I use a qcow2 image(virtual size: 10 GiB, disk size: 1.8 GiB) as a
> child of quorum, then the destination image become larger(virtual size: 10
> GiB, disk size: 10 GiB). However if I use a qcow2 image directly, then the
> destination image(virtual size: 10 GiB, disk size: 1.8 GiB) will be equal to
> the source.
>
> So I am wondering if my usage is wrong or it is expected with
> quorum+drive-mirror?
This seems to be because the quorum block driver doesn't implement the
.bdrv_co_block_status interface, so the mirror block job can't know that
some blocks are unallocated/zeroed, but will copy everything.
I'm not sure if quorum can even implement this interface because the
allocation status in different quorum children may differ and voting
might not make sense. But maybe it could return a limited set of flags
at least so that the mirror job can get the BDRV_BLOCK_ZERO information
if the quorum children agree on it.
tl;dr: With quorum + drive-mirror it is currently expected.
Kevin
next prev parent reply other threads:[~2020-05-19 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 8:32 Migration with ``drive-mirror`` + NBD will let quorum qcow2 image become larger Tao Xu
2020-05-19 9:15 ` Kevin Wolf [this message]
2020-05-19 14:49 ` Alberto Garcia
2020-05-20 8:36 ` Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519091544.GD7652@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=chen.zhang@intel.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).