qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 06/15] tests/fp: split and audit the conversion tests
Date: Wed, 20 May 2020 15:05:32 +0100	[thread overview]
Message-ID: <20200520140541.30256-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200520140541.30256-1-alex.bennee@linaro.org>

Split the float conversion tests into separate groups and audit the
tests to check what is still broken. I was able to enable a bunch of
tests that had been missed before:

  all the float to float conversions
  ui32_to_extF80
  ui64_to_extF80
  extF80_to_ui32
  extF80_to_ui32_r_minMag
  extF80_to_ui64
  extF80_to_ui64_r_minMag

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/Makefile.include | 37 ++++++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index e6d87fcbf0e..a00ccc94b8b 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -687,11 +687,26 @@ test-softfloat = $(call quiet-command, \
 			(cat $2.out && exit 1;), \
 			"FLOAT TEST", $2)
 
-# Conversion Routines:
+# Conversion Routines: Float to Float
+# FIXME: f32_to_f128 (broken), f64_to_f128 (broken)
+# FIXME: f128_to_f32(broken), f128_to_f64 (broken)
+# FIXME: f128_to_extF80 (broken)
+check-softfloat-conv-f2f: $(FP_TEST_BIN)
+	$(call test-softfloat, \
+		f16_to_f32 f16_to_f64 \
+		f16_to_extF80 f16_to_f128 \
+		f32_to_f16 f32_to_f64 \
+		f32_to_extF80 \
+		f64_to_f16 f64_to_f32 \
+		extF80_to_f16 extF80_to_f32 \
+		extF80_to_f64 extF80_to_f128 \
+		f128_to_f16, \
+		float-to-float)
+
+# Conversion Routines: Int and Uint to Float
 # FIXME: i32_to_extF80 (broken), i64_to_extF80 (broken)
-#        ui32_to_f128 (not implemented), extF80_roundToInt (broken)
-#
-check-softfloat-conv: $(FP_TEST_BIN)
+#        ui32_to_f128 (not implemented)
+check-softfloat-conv-to-float: $(FP_TEST_BIN)
 	$(call test-softfloat, \
 		i32_to_f16 i64_to_f16 \
 		i32_to_f32 i64_to_f32 \
@@ -701,7 +716,12 @@ check-softfloat-conv: $(FP_TEST_BIN)
 		ui32_to_f16 ui64_to_f16 \
 		ui32_to_f32 ui64_to_f32 \
 		ui32_to_f64 ui64_to_f64 \
+		ui32_to_extF80 ui64_to_extF80 \
 		ui64_to_f128, uint-to-float)
+
+# Conversion Routines: Float to integers
+# FIXME: extF80_roundToInt (broken)
+check-softfloat-conv-to-int: $(FP_TEST_BIN)
 	$(call test-softfloat, \
 		f16_to_i32 f16_to_i32_r_minMag \
 		f32_to_i32 f32_to_i32_r_minMag \
@@ -718,10 +738,12 @@ check-softfloat-conv: $(FP_TEST_BIN)
 		f16_to_ui32 f16_to_ui32_r_minMag \
 		f32_to_ui32 f32_to_ui32_r_minMag \
 		f64_to_ui32 f64_to_ui32_r_minMag \
+		extF80_to_ui32 extF80_to_ui32_r_minMag \
 		f128_to_ui32 f128_to_ui32_r_minMag \
 		f16_to_ui64 f16_to_ui64_r_minMag \
 		f32_to_ui64 f32_to_ui64_r_minMag \
 		f64_to_ui64 f64_to_ui64_r_minMag \
+		extF80_to_ui64 extF80_to_ui64_r_minMag \
 		f128_to_ui64 f128_to_ui64_r_minMag, \
 		float-to-uint)
 	$(call test-softfloat, \
@@ -729,9 +751,14 @@ check-softfloat-conv: $(FP_TEST_BIN)
 		f64_roundToInt f128_roundToInt, \
 		round-to-integer)
 
+.PHONY: check-softfloat-conv
+check-softfloat-conv: check-softfloat-conv-f2f
+check-softfloat-conv: check-softfloat-conv-to-float
+check-softfloat-conv: check-softfloat-conv-to-int
+
 # Generic rule for all float operations
 #
-# Some patterns are overidden due to broken or missing tests.
+# Some patterns are overridden due to broken or missing tests.
 # Hopefully these can be removed over time.
 
 check-softfloat-%: $(FP_TEST_BIN)
-- 
2.20.1



  parent reply	other threads:[~2020-05-20 14:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 14:05 [PATCH v1 00/15] testing and plugin updates Alex Bennée
2020-05-20 14:05 ` [PATCH v1 01/15] configure: add alternate binary for genisoimage Alex Bennée
2020-05-20 14:05 ` [PATCH v1 02/15] tests/vm: pass --genisoimage to basevm script Alex Bennée
2020-05-20 14:05 ` [PATCH v1 03/15] travis.yml: Use clang++ in the Clang tests Alex Bennée
2020-05-20 14:05 ` [PATCH v1 04/15] tests/tcg: fix invocation of the memory record/replay tests Alex Bennée
2020-05-20 14:05 ` [PATCH v1 05/15] tests/fp: enable extf80_le_quite tests Alex Bennée
2020-05-22  2:59   ` Richard Henderson
2020-05-20 14:05 ` Alex Bennée [this message]
2020-05-22  3:00   ` [PATCH v1 06/15] tests/fp: split and audit the conversion tests Richard Henderson
2020-05-20 14:05 ` [PATCH v1 07/15] tests/tcg: better detect confused gdb which can't connect Alex Bennée
2020-05-22  3:01   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 08/15] tests/docker: bump fedora to 32 Alex Bennée
2020-05-22  3:01   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 09/15] tests/docker: add debian11 base image Alex Bennée
2020-05-22  3:01   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 10/15] tests/docker: use a gcc-10 based image for arm64 tests Alex Bennée
2020-05-22  3:02   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 11/15] tests/tcg/aarch64: Add bti smoke test Alex Bennée
2020-05-22  3:05   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 12/15] cpus-common: ensure auto-assigned cpu_indexes don't clash Alex Bennée
2020-05-22  3:20   ` Richard Henderson
2020-05-20 14:05 ` [PATCH v1 13/15] linux-user: properly "unrealize" vCPU object Alex Bennée
2020-05-20 14:05 ` [PATCH v1 14/15] tests/tcg: add new threadcount test Alex Bennée
2020-05-20 14:05 ` [PATCH v1 15/15] plugins: new lockstep plugin for debugging TCG changes Alex Bennée
2020-05-20 16:37 ` [PATCH v1 00/15] testing and plugin updates no-reply
2020-05-20 16:38 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520140541.30256-7-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).