From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com
Cc: berrange@redhat.com, clg@kaod.org, afaerber@suse.de
Subject: [PATCH 0/2] HMP: qom-get and set
Date: Wed, 20 May 2020 16:11:06 +0100 [thread overview]
Message-ID: <20200520151108.160598-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
HMP has had a qom-set for a long time, but not a matching qom-get;
various attempts have been made to add one over the last 5 years.
Here's another go.
It's got simpler due to a suggestion by Markus to take the output
from qmp's qom-get. While we're here, rework hmp's qom-set to be
a wrapper around the qmp equivalent, which simplifies it a bit.
In one post people didn't particularly like the use of JSON,
but in the intervening 4 years no one has implemented anything to
avoid it, and the output is trivially readable for non-structures
and still pretty readable for (the very rare) structures.
Dave
Dr. David Alan Gilbert (2):
hmp: Implement qom-get HMP command
hmp: Simplify qom_set
hmp-commands.hx | 14 ++++++++++++++
include/monitor/hmp.h | 1 +
qom/qom-hmp-cmds.c | 34 +++++++++++++++++++++++-----------
tests/qtest/test-hmp.c | 1 +
4 files changed, 39 insertions(+), 11 deletions(-)
--
2.26.2
next reply other threads:[~2020-05-20 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 15:11 Dr. David Alan Gilbert (git) [this message]
2020-05-20 15:11 ` [PATCH 1/2] hmp: Implement qom-get HMP command Dr. David Alan Gilbert (git)
2020-05-20 16:44 ` Philippe Mathieu-Daudé
2020-05-25 9:02 ` Markus Armbruster
2020-05-29 6:59 ` Markus Armbruster
2020-05-20 15:11 ` [PATCH 2/2] hmp: Simplify qom_set Dr. David Alan Gilbert (git)
2020-05-20 16:47 ` Philippe Mathieu-Daudé
2020-05-20 19:03 ` Dr. David Alan Gilbert
2020-05-25 8:54 ` Markus Armbruster
2020-05-28 14:06 ` Dr. David Alan Gilbert
2020-05-28 15:12 ` Philippe Mathieu-Daudé
2020-05-29 6:20 ` Markus Armbruster
2020-05-29 9:07 ` Dr. David Alan Gilbert
2020-05-29 18:48 ` [PATCH 0/2] HMP: qom-get and set Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520151108.160598-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).