From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886CEC433DF for ; Wed, 20 May 2020 15:54:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4854320671 for ; Wed, 20 May 2020 15:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jBdHwLzX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4854320671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbR2l-0007go-FW for qemu-devel@archiver.kernel.org; Wed, 20 May 2020 11:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbR1o-0006E3-Gn for qemu-devel@nongnu.org; Wed, 20 May 2020 11:53:08 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:27651 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jbR1n-0001CX-Rk for qemu-devel@nongnu.org; Wed, 20 May 2020 11:53:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589989987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MWxes5zfMaG9o/8NEN/0d/Rm32meUmr2iQZPwMdi3lg=; b=jBdHwLzXf2D1d+8swKSSZ29XBhIOvKmhnTPnd/SmsmTA5X3jXIDGFKOl/Qfa145wb207hf CHjQho7IWSH/G7kBxu72bNW2AqlrTK8e0KCpw7P+3S+Nr5+5cfGf8PqhP8Ctb+TnrQMoek tKP4apx0A9eRUHjSD38RlHEmErCV4p8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-d951aKoFOkGPom9rMP8BQg-1; Wed, 20 May 2020 11:53:05 -0400 X-MC-Unique: d951aKoFOkGPom9rMP8BQg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4AA531005510; Wed, 20 May 2020 15:53:04 +0000 (UTC) Received: from work-vm (ovpn-114-169.ams2.redhat.com [10.36.114.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7C455D9E2; Wed, 20 May 2020 15:52:56 +0000 (UTC) Date: Wed, 20 May 2020 16:52:54 +0100 From: "Dr. David Alan Gilbert" To: David Hildenbrand Subject: Re: [PATCH v2 07/19] migration/rdma: Use ram_block_discard_disable() Message-ID: <20200520155254.GE2820@work-vm> References: <20200520123152.60527-1-david@redhat.com> <20200520123152.60527-8-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520123152.60527-8-david@redhat.com> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Received-SPF: pass client-ip=207.211.31.81; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/20 04:09:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_HK_NAME_DR=0.01 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm@vger.kernel.org, "Michael S . Tsirkin" , Juan Quintela , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * David Hildenbrand (david@redhat.com) wrote: > RDMA will pin all guest memory (as documented in docs/rdma.txt). We want > to disable RAM block discards - however, to keep it simple use > ram_block_discard_is_required() instead of inhibiting. > > Note: It is not sufficient to limit disabling to pin_all. Even when only > conditionally pinning 1 MB chunks, as soon as one page within such a > chunk was discarded and one page not, the discarded pages will be pinned > as well. > > Cc: "Michael S. Tsirkin" > Cc: Juan Quintela > Cc: "Dr. David Alan Gilbert" > Signed-off-by: David Hildenbrand Reviewed-by: Dr. David Alan Gilbert > --- > migration/rdma.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/migration/rdma.c b/migration/rdma.c > index 967fda5b0c..57e2cbc8ca 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -29,6 +29,7 @@ > #include "qemu/sockets.h" > #include "qemu/bitmap.h" > #include "qemu/coroutine.h" > +#include "exec/memory.h" > #include > #include > #include > @@ -4017,8 +4018,14 @@ void rdma_start_incoming_migration(const char *host_port, Error **errp) > Error *local_err = NULL; > > trace_rdma_start_incoming_migration(); > - rdma = qemu_rdma_data_init(host_port, &local_err); > > + /* Avoid ram_block_discard_disable(), cannot change during migration. */ > + if (ram_block_discard_is_required()) { > + error_setg(errp, "RDMA: cannot disable RAM discard"); > + return; > + } > + > + rdma = qemu_rdma_data_init(host_port, &local_err); > if (rdma == NULL) { > goto err; > } > @@ -4065,10 +4072,17 @@ void rdma_start_outgoing_migration(void *opaque, > const char *host_port, Error **errp) > { > MigrationState *s = opaque; > - RDMAContext *rdma = qemu_rdma_data_init(host_port, errp); > RDMAContext *rdma_return_path = NULL; > + RDMAContext *rdma; > int ret = 0; > > + /* Avoid ram_block_discard_disable(), cannot change during migration. */ > + if (ram_block_discard_is_required()) { > + error_setg(errp, "RDMA: cannot disable RAM discard"); > + return; > + } > + > + rdma = qemu_rdma_data_init(host_port, errp); > if (rdma == NULL) { > goto err; > } > -- > 2.25.4 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK