From: Roman Kagan <rvkagan@yandex-team.ru>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"John Snow" <jsnow@redhat.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size
Date: Wed, 20 May 2020 23:34:12 +0300 [thread overview]
Message-ID: <20200520203412.GA104207@rvkaganb.lan> (raw)
In-Reply-To: <20200520153658.GD5192@linux.fritz.box>
On Wed, May 20, 2020 at 05:36:58PM +0200, Kevin Wolf wrote:
> Am 20.05.2020 um 10:06 hat Roman Kagan geschrieben:
> > The width of opt_io_size in virtio_blk_topology is 32bit.
>
> I think you mean virtio_blk_config?
I consulted virtio-v1.1 spec where the topology-related fields are
grouped in struct virtio_blk_topology; I didn't realize in Linux (and
therefore in QEMU) these fields lay directly on virtio_blk_config. So
yes, the log should read "virtio_blk_config", thanks for spotting!
> > Use the appropriate accessor to store it.
> >
> > Signed-off-by: Roman Kagan <rvkagan@yandex-team.ru>
>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
Thanks,
Roman.
next prev parent reply other threads:[~2020-05-20 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:06 [PATCH v4 0/3] block: make BlockConf.*_size properties 32-bit Roman Kagan
2020-05-20 8:06 ` [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size Roman Kagan
2020-05-20 8:48 ` Philippe Mathieu-Daudé
2020-05-20 10:44 ` Michael S. Tsirkin
2020-05-20 21:11 ` Roman Kagan
2020-05-20 15:36 ` Kevin Wolf
2020-05-20 20:34 ` Roman Kagan [this message]
2020-05-20 8:06 ` [PATCH v4 2/3] block: consolidate blocksize properties consistency checks Roman Kagan
2020-05-20 8:57 ` Philippe Mathieu-Daudé
2020-05-20 8:59 ` Philippe Mathieu-Daudé
2020-05-20 15:52 ` Kevin Wolf
2020-05-20 15:50 ` Kevin Wolf
2020-05-20 21:31 ` Roman Kagan
2020-05-20 8:06 ` [PATCH v4 3/3] block: make BlockConf.*_size properties 32-bit Roman Kagan
2020-05-20 9:04 ` Philippe Mathieu-Daudé
2020-05-20 21:45 ` Roman Kagan
2020-05-20 15:54 ` Kevin Wolf
2020-05-20 21:50 ` Roman Kagan
2020-05-25 15:20 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520203412.GA104207@rvkaganb.lan \
--to=rvkagan@yandex-team.ru \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).