From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 541B6C433DF for ; Wed, 20 May 2020 20:35:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16751204EC for ; Wed, 20 May 2020 20:35:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=yandex-team.ru header.i=@yandex-team.ru header.b="MfcK7nHL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16751204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=yandex-team.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbVQz-0001jH-7e for qemu-devel@archiver.kernel.org; Wed, 20 May 2020 16:35:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbVQ4-000101-HL; Wed, 20 May 2020 16:34:28 -0400 Received: from forwardcorp1o.mail.yandex.net ([2a02:6b8:0:1a2d::193]:49706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbVQ0-0005GC-97; Wed, 20 May 2020 16:34:26 -0400 Received: from mxbackcorp1j.mail.yandex.net (mxbackcorp1j.mail.yandex.net [IPv6:2a02:6b8:0:1619::162]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 32A0C2E1611; Wed, 20 May 2020 23:34:17 +0300 (MSK) Received: from myt5-70c90f7d6d7d.qloud-c.yandex.net (myt5-70c90f7d6d7d.qloud-c.yandex.net [2a02:6b8:c12:3e2c:0:640:70c9:f7d]) by mxbackcorp1j.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id sxdwlYouWJ-YET8Y5kp; Wed, 20 May 2020 23:34:17 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1590006857; bh=cJFepITFgv6/qbGwXmtuM5z07EQszl6YMb073OIWKSk=; h=In-Reply-To:Message-ID:Subject:To:From:References:Date:Cc; b=MfcK7nHLME+23MjzVMWCaHFoINjaAKWt72ChgH9ahR/7kru2V24mOE4C4a8ECtm3R Ge7FFv8d2T+94U4NoLCNQ5E+UgwY9va4VF/8tD/xDUiFa+E0/TVVXmtGu7pP4MKo9Y ibkaJKXnap/e0fFbTiD6vzvZhTe8O95fieVcJ2d4= Authentication-Results: mxbackcorp1j.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b081:407::1:16]) by myt5-70c90f7d6d7d.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id D8iynLIZMi-YDXa4lIc; Wed, 20 May 2020 23:34:14 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Date: Wed, 20 May 2020 23:34:12 +0300 From: Roman Kagan To: Kevin Wolf Subject: Re: [PATCH v4 1/3] virtio-blk: store opt_io_size with correct size Message-ID: <20200520203412.GA104207@rvkaganb.lan> Mail-Followup-To: Roman Kagan , Kevin Wolf , qemu-devel@nongnu.org, Eduardo Habkost , Keith Busch , Stefan Hajnoczi , Gerd Hoffmann , Fam Zheng , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eric Blake , "Michael S. Tsirkin" , qemu-block@nongnu.org, John Snow , Paolo Bonzini , Max Reitz References: <20200520080657.29080-1-rvkagan@yandex-team.ru> <20200520080657.29080-2-rvkagan@yandex-team.ru> <20200520153658.GD5192@linux.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520153658.GD5192@linux.fritz.box> Received-SPF: pass client-ip=2a02:6b8:0:1a2d::193; envelope-from=rvkagan@yandex-team.ru; helo=forwardcorp1o.mail.yandex.net X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , John Snow , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann , Stefan Hajnoczi , Keith Busch , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 20, 2020 at 05:36:58PM +0200, Kevin Wolf wrote: > Am 20.05.2020 um 10:06 hat Roman Kagan geschrieben: > > The width of opt_io_size in virtio_blk_topology is 32bit. > > I think you mean virtio_blk_config? I consulted virtio-v1.1 spec where the topology-related fields are grouped in struct virtio_blk_topology; I didn't realize in Linux (and therefore in QEMU) these fields lay directly on virtio_blk_config. So yes, the log should read "virtio_blk_config", thanks for spotting! > > Use the appropriate accessor to store it. > > > > Signed-off-by: Roman Kagan > > Reviewed-by: Kevin Wolf > Thanks, Roman.