From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BE2C433DF for ; Fri, 22 May 2020 11:51:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E296206B6 for ; Fri, 22 May 2020 11:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ADKhULdR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E296206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jc6DK-0004Ja-O5 for qemu-devel@archiver.kernel.org; Fri, 22 May 2020 07:51:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jc6Cb-00037V-Fj; Fri, 22 May 2020 07:51:01 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:40358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jc6Ca-0004cD-Md; Fri, 22 May 2020 07:51:01 -0400 Received: by mail-wm1-x341.google.com with SMTP id n18so9542725wmj.5; Fri, 22 May 2020 04:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PeC4/6Bbi6vdN3UI8jEqDsfyPpIFP8TzdU+CFw09D9g=; b=ADKhULdRIiNbFVy02LOfvd5zmaNxrf7Z4KbicuV+8XD0qVronN+0P7D8bxRubcT5MM lWe7eLoX2Eb4Or4Q0zJ6T6ArEMh1eYC32ShM0c6MP6rKW9R7pWDB34B5CUABBzCp92Ji 9nQR88FRqpTUH4zD68crT6+oDHRVwGLDg8ZCJbpMBoLRpe5OenbHpM/hhTuwZpcb9tQa UmkdCP/VjIKuPQYmwXi85DXXhjgcL+erK/2wmhE1wu+F7rOmFsMmkEhnjsLb8tvd/Imy GLU3jU/VgzJTlltHe0niEOmj5z4YumfyGBns/DiG0YZJGSUH5ezQNKSOHX2V4AQSF3Wr NlNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PeC4/6Bbi6vdN3UI8jEqDsfyPpIFP8TzdU+CFw09D9g=; b=FcSSTqG3czcPSBYdlNImhyfOd0hwG6LzsGdGZRJaogZrTtn6tTOUYQpEH5bgEtFD74 UPOSFdplzpgPTsattl72d3UgVGgImxlYfnm2YfBfmtszDF2Tz5+kHJrXM9Wo+NYNoqNv wnfhayVcoecU5uQrFTzDj2NTVvQ+f0KnpHNTH7wxbUvoIkzVrpZHwT8T9B6XG4t6lvHT R4QPL6fNsP1lbwSPDJcYCGf3cAdfth1Opu47s3knpqD895hAJP60hnwR1DIKlgaDVOb4 FMvgzK6dUZ7OHkZhXV60IQLRE4+JJHqnuQooxE8I+NQGtsa4hT1Q02Dpqs94bmXMj0os rVlg== X-Gm-Message-State: AOAM533qIcqRZdVPwayLAe3AzPxgHAMouUZmVy91EQ5RwGhIeVbkHFtI urBd/kcEWbpdmjYHHp06qFw= X-Google-Smtp-Source: ABdhPJzzRmK9cbyw8ZhU+vxusWoRYy4Q85ElqbfHsOOYpIrcUHzI9TvsXvPlT/EpZah+81CQG6fLNw== X-Received: by 2002:a1c:3286:: with SMTP id y128mr12994051wmy.119.1590148258773; Fri, 22 May 2020 04:50:58 -0700 (PDT) Received: from eden-linux.lan (bzq-109-66-59-205.red.bezeqint.net. [109.66.59.205]) by smtp.gmail.com with ESMTPSA id m3sm9237640wrn.96.2020.05.22.04.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 04:50:58 -0700 (PDT) From: Eden Mikitas To: peter.maydell@linaro.org Subject: [PATCH 1/2] hw/ssi/imx_spi: changed while statement to prevent underflow Date: Fri, 22 May 2020 14:50:35 +0300 Message-Id: <20200522115036.31516-2-e.mikitas@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200522115036.31516-1-e.mikitas@gmail.com> References: <20200522115036.31516-1-e.mikitas@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::341; envelope-from=e.mikitas@gmail.com; helo=mail-wm1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, alistair@alistair23.me, qemu-devel@nongnu.org, jcd@tribudubois.net, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, e.mikitas@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The while statement in question only checked if tx_burst is not 0. tx_burst is a signed int, which is assigned the value put by the guest driver in ECSPI_CONREG. The burst length can be anywhere between 1 and 4096, and since tx_burst is always decremented by 8 it could possibly underflow, causing an infinite loop. Signed-off-by: Eden Mikitas --- hw/ssi/imx_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 2dd9a631e1..6fef5c7958 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -182,7 +182,7 @@ static void imx_spi_flush_txfifo(IMXSPIState *s) rx = 0; - while (tx_burst) { + while (tx_burst > 0) { uint8_t byte = tx & 0xff; DPRINTF("writing 0x%02x\n", (uint32_t)byte); -- 2.17.1