From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
jasowang@redhat.com, cohuck@redhat.com,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Max Reitz" <mreitz@redhat.com>
Subject: [PATCH 1/5] tests/libqos: mask out VIRTIO_F_RING_PACKED for now
Date: Fri, 22 May 2020 18:17:22 +0100 [thread overview]
Message-ID: <20200522171726.648279-2-stefanha@redhat.com> (raw)
In-Reply-To: <20200522171726.648279-1-stefanha@redhat.com>
The libqos VIRTIO code does not implement the packed virtqueue layout
yet. Mask out the feature bit for now because tests have a habit of
enabling all device feature bits and we don't want packed virtqueues to
be enabled.
Later patches will enable VIRTIO_F_RING_PACKED so prepare libqos now.
Cc: Thomas Huth <thuth@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/qtest/libqos/virtio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/libqos/virtio.c b/tests/qtest/libqos/virtio.c
index 9aa360620c..1c3f4a0c8b 100644
--- a/tests/qtest/libqos/virtio.c
+++ b/tests/qtest/libqos/virtio.c
@@ -96,7 +96,8 @@ uint64_t qvirtio_config_readq(QVirtioDevice *d, uint64_t addr)
uint64_t qvirtio_get_features(QVirtioDevice *d)
{
- return d->bus->get_features(d);
+ /* qvirtio does not support packed virtqueues yet */
+ return d->bus->get_features(d) & ~(1ull << VIRTIO_F_RING_PACKED);
}
void qvirtio_set_features(QVirtioDevice *d, uint64_t features)
--
2.25.3
next prev parent reply other threads:[~2020-05-22 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 17:17 [PATCH 0/5] virtio: enable VIRTIO_F_RING_PACKED for all devices Stefan Hajnoczi
2020-05-22 17:17 ` Stefan Hajnoczi [this message]
2020-05-22 19:21 ` [PATCH 1/5] tests/libqos: mask out VIRTIO_F_RING_PACKED for now Thomas Huth
2020-05-22 17:17 ` [PATCH 2/5] vhost: involve device backends in feature negotiation Stefan Hajnoczi
2020-05-27 14:28 ` Marc-André Lureau
2020-05-29 15:20 ` Stefan Hajnoczi
2020-05-29 7:04 ` Jason Wang
2020-05-29 13:56 ` Stefan Hajnoczi
2020-05-29 14:29 ` Dr. David Alan Gilbert
2020-06-03 14:44 ` Stefan Hajnoczi
2020-06-01 12:51 ` Jason Wang
2020-06-03 14:39 ` Stefan Hajnoczi
2020-05-22 17:17 ` [PATCH 3/5] vhost-user-blk: add VIRTIO_F_RING_PACKED feature bit Stefan Hajnoczi
2020-05-25 4:06 ` Raphael Norwitz
2020-05-22 17:17 ` [PATCH 4/5] vhost-scsi: add VIRTIO_F_VERSION_1 and VIRTIO_F_RING_PACKED Stefan Hajnoczi
2020-05-25 4:02 ` Raphael Norwitz
2020-05-22 17:17 ` [PATCH 5/5] virtio: enable VIRTIO_F_RING_PACKED for all devices Stefan Hajnoczi
2020-05-26 17:29 ` Dr. David Alan Gilbert
2020-05-29 7:15 ` Jason Wang
2020-05-29 15:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522171726.648279-2-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).