From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PULL 6/8] audio: Let audio_sample_to_uint64() use const samples argument
Date: Tue, 26 May 2020 09:56:37 +0200 [thread overview]
Message-ID: <20200526075639.27949-7-kraxel@redhat.com> (raw)
In-Reply-To: <20200526075639.27949-1-kraxel@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
The samples are the input to convert to u64. As we should
not modify them, mark the argument const.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200505132603.8575-2-f4bug@amsat.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/audio.h | 2 +-
audio/mixeng.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/audio/audio.h b/audio/audio.h
index 0db3c7dd5e06..f27a12298fe5 100644
--- a/audio/audio.h
+++ b/audio/audio.h
@@ -163,7 +163,7 @@ int wav_start_capture(AudioState *state, CaptureState *s, const char *path,
bool audio_is_cleaning_up(void);
void audio_cleanup(void);
-void audio_sample_to_uint64(void *samples, int pos,
+void audio_sample_to_uint64(const void *samples, int pos,
uint64_t *left, uint64_t *right);
void audio_sample_from_uint64(void *samples, int pos,
uint64_t left, uint64_t right);
diff --git a/audio/mixeng.c b/audio/mixeng.c
index 924dcb858af5..f27deb165b67 100644
--- a/audio/mixeng.c
+++ b/audio/mixeng.c
@@ -339,10 +339,10 @@ f_sample *mixeng_clip_float[2] = {
clip_natural_float_from_stereo,
};
-void audio_sample_to_uint64(void *samples, int pos,
+void audio_sample_to_uint64(const void *samples, int pos,
uint64_t *left, uint64_t *right)
{
- struct st_sample *sample = samples;
+ const struct st_sample *sample = samples;
sample += pos;
#ifdef FLOAT_MIXENG
error_report(
--
2.18.4
next prev parent reply other threads:[~2020-05-26 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 7:56 [PULL 0/8] Audio 20200526 patches Gerd Hoffmann
2020-05-26 7:56 ` [PULL 1/8] es1370: check total frame count against current frame Gerd Hoffmann
2020-05-26 7:56 ` [PULL 2/8] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h' Gerd Hoffmann
2020-05-26 7:56 ` [PULL 3/8] audio/jack: add JACK client audiodev Gerd Hoffmann
2020-05-26 7:56 ` [PULL 4/8] audio/mixeng: fix clang 10+ warning Gerd Hoffmann
2020-05-26 7:56 ` [PULL 5/8] audio: fix wavcapture segfault Gerd Hoffmann
2020-05-26 7:56 ` Gerd Hoffmann [this message]
2020-05-26 7:56 ` [PULL 7/8] audio: Let capture_callback handler use const buffer argument Gerd Hoffmann
2020-05-26 7:56 ` [PULL 8/8] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include Gerd Hoffmann
2020-05-26 13:05 ` [PULL 0/8] Audio 20200526 patches Peter Maydell
2020-05-27 6:30 ` Markus Armbruster
2020-05-27 9:56 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526075639.27949-7-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).