qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PULL 7/8] audio: Let capture_callback handler use const buffer argument
Date: Tue, 26 May 2020 09:56:38 +0200	[thread overview]
Message-ID: <20200526075639.27949-8-kraxel@redhat.com> (raw)
In-Reply-To: <20200526075639.27949-1-kraxel@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

The buffer is the captured input to pass to backends.
As we should not modify it, mark the argument const.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200505132603.8575-3-f4bug@amsat.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 audio/audio.h      | 2 +-
 audio/wavcapture.c | 2 +-
 ui/vnc.c           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/audio/audio.h b/audio/audio.h
index f27a12298fe5..b883ebfb1f8e 100644
--- a/audio/audio.h
+++ b/audio/audio.h
@@ -60,7 +60,7 @@ typedef enum {
 
 struct audio_capture_ops {
     void (*notify) (void *opaque, audcnotification_e cmd);
-    void (*capture) (void *opaque, void *buf, int size);
+    void (*capture) (void *opaque, const void *buf, int size);
     void (*destroy) (void *opaque);
 };
 
diff --git a/audio/wavcapture.c b/audio/wavcapture.c
index 8d7ce2eda145..17e87ed6f45e 100644
--- a/audio/wavcapture.c
+++ b/audio/wavcapture.c
@@ -71,7 +71,7 @@ static void wav_destroy (void *opaque)
     g_free (wav->path);
 }
 
-static void wav_capture (void *opaque, void *buf, int size)
+static void wav_capture(void *opaque, const void *buf, int size)
 {
     WAVState *wav = opaque;
 
diff --git a/ui/vnc.c b/ui/vnc.c
index 1d7138a3a073..12a12714e129 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1177,7 +1177,7 @@ static void audio_capture_destroy(void *opaque)
 {
 }
 
-static void audio_capture(void *opaque, void *buf, int size)
+static void audio_capture(void *opaque, const void *buf, int size)
 {
     VncState *vs = opaque;
 
-- 
2.18.4



  parent reply	other threads:[~2020-05-26  7:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  7:56 [PULL 0/8] Audio 20200526 patches Gerd Hoffmann
2020-05-26  7:56 ` [PULL 1/8] es1370: check total frame count against current frame Gerd Hoffmann
2020-05-26  7:56 ` [PULL 2/8] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h' Gerd Hoffmann
2020-05-26  7:56 ` [PULL 3/8] audio/jack: add JACK client audiodev Gerd Hoffmann
2020-05-26  7:56 ` [PULL 4/8] audio/mixeng: fix clang 10+ warning Gerd Hoffmann
2020-05-26  7:56 ` [PULL 5/8] audio: fix wavcapture segfault Gerd Hoffmann
2020-05-26  7:56 ` [PULL 6/8] audio: Let audio_sample_to_uint64() use const samples argument Gerd Hoffmann
2020-05-26  7:56 ` Gerd Hoffmann [this message]
2020-05-26  7:56 ` [PULL 8/8] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include Gerd Hoffmann
2020-05-26 13:05 ` [PULL 0/8] Audio 20200526 patches Peter Maydell
2020-05-27  6:30 ` Markus Armbruster
2020-05-27  9:56   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526075639.27949-8-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=armbru@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).