From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DF5C433DF for ; Tue, 26 May 2020 10:57:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E401B2084C for ; Tue, 26 May 2020 10:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SCFN2Gvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E401B2084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdXGf-0006KJ-6L for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 06:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdX7l-0007G3-7F for qemu-devel@nongnu.org; Tue, 26 May 2020 06:47:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60055 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdX7k-0002Ci-8s for qemu-devel@nongnu.org; Tue, 26 May 2020 06:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590490075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9ElR8/TiWTLU4MenHCo/KuQT+CrmA8r6BBjyiu48rJs=; b=SCFN2GvzDjhCH9VDdhJNDAr1DC+7g/EYd1mE/+ZTZmAt9+/xhl7QXHrmY+h31EUcmR0o8T 0DdTmgJydI5UT6kpVG9xKrdEvdZkY7OSvgxcZX2/PwBq8oXuKfcWXN0TDJPmZruO/7FWjP MIWdUkwt22ykaDQvyNIu8M0mp+Zd5gQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-isFpXgsrP2287zNLfysvtg-1; Tue, 26 May 2020 06:47:52 -0400 X-MC-Unique: isFpXgsrP2287zNLfysvtg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 986AF19057A6; Tue, 26 May 2020 10:47:50 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-50.ams2.redhat.com [10.36.113.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2376B60C47; Tue, 26 May 2020 10:47:50 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3810F16E2C; Tue, 26 May 2020 12:47:48 +0200 (CEST) Date: Tue, 26 May 2020 12:47:48 +0200 From: Gerd Hoffmann To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 11/14] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion Message-ID: <20200526104748.wayie5aovk5omz3t@sirius.home.kraxel.org> References: <20200526062252.19852-1-f4bug@amsat.org> <20200526062252.19852-12-f4bug@amsat.org> <20200526080123.ul5r4abphqfi7lkq@sirius.home.kraxel.org> <4a6478f2-6b70-40df-093f-e81d2437bfa7@amsat.org> MIME-Version: 1.0 In-Reply-To: <4a6478f2-6b70-40df-093f-e81d2437bfa7@amsat.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/26 01:19:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Alistair Francis , Mark Cave-Ayland , qemu-devel@nongnu.org, Igor Mitsyanko , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, May 26, 2020 at 10:16:19AM +0200, Philippe Mathieu-Daudé wrote: > On 5/26/20 10:01 AM, Gerd Hoffmann wrote: > > On Tue, May 26, 2020 at 08:22:49AM +0200, Philippe Mathieu-Daudé wrote: > >> To avoid the orphan I/O memory region being added in the /unattached > >> QOM container, register the PCI device as its owner. > >> > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> RFC: This might break migration > > > > --verbose please. This doesn't touch the live migration data stream? > > Oops, this is an I/O region... I was confused by this warning form Peter: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg681970.html > > But it is restricted to RAM regions, so this patch is harmless. Yes, for ram regions this is a problem, this is why vga has global_vmstate. No problem for io. Series looks fine then. take care, Gerd