From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1CEDC433E0 for ; Tue, 26 May 2020 13:43:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 877CD2068D for ; Tue, 26 May 2020 13:43:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lMlVcpz0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 877CD2068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdZrB-0005rg-Ok for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 09:43:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdZhe-0006i6-6A for qemu-devel@nongnu.org; Tue, 26 May 2020 09:33:10 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:39625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdZhd-0005q1-AH for qemu-devel@nongnu.org; Tue, 26 May 2020 09:33:09 -0400 Received: by mail-ed1-x532.google.com with SMTP id bs4so17664112edb.6 for ; Tue, 26 May 2020 06:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=45UgqB7xiuv75to9D1xtOkBXTGrFM8LHRPwW44N+AXY=; b=lMlVcpz0SEIHftLhoQiMt7/WH3AV8k4VJ0N3MnAEPF3rmB4l7XvEf7f4yzJBEKR9uQ f1ahyKK350n4yr4ndcK8b9MsHa/Sf+gY39OlUK041+lL3Pv2PHQgkzXSvMnIjvqGr8oM eLKFHulqOfvYodVHPCtjgvsdsWPWXAodT4LRFZ6ad9Y7qtX5qN095sVCdp73vihJYnFg NJCxrjcxJZNnl2qWQCSHXk4iX4hXGmQw/FbEDc7t24GNXjYwnZznSlvkbvNQ2GbXp6A0 EzBRmWZIv+YOZhKKkNUKHNqP03HIL5iqaK3BmTsFLf48cnRarMO2EJYuqN+LprfZYU9N YSew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=45UgqB7xiuv75to9D1xtOkBXTGrFM8LHRPwW44N+AXY=; b=tVDODE2gbouLRLj/YWj98atfFdVJq15LQtQLqdMFHN1oicU0YOAyckPXHn6QzUe2oO ID8tu25rDD1ETg3TYuNQHSbZoPBtFO7ZLzhiQghoVXXK8ndEXGezvuHj9s/e+xJV8dIO 0iUpAwtQMyyIQkew5yG7l8iXWSQ9tXMh8kxuR2zbaKwioSJIkhBRKvMQ0JyiQNhMBlU7 WLKLCbe1OiBpD5T9WyFIlIrFkiRf3fEqTYmyMLV05tTeMjx9036SglyShTNOylxmUJsN FfP13YMcFEZPgfBSyGByMg6QWNutaHh38f/UlLB6INubHlvDkUrxUkBlgDeLodu86uSZ DMbQ== X-Gm-Message-State: AOAM531MGJAdgFBWa8fFibWR+R2wVJQ8/Ki4fQ/YAcCOx8j9hP61gUqy KAiLNxwInH/JZj7qGzBULMOB2Tn/ty4= X-Google-Smtp-Source: ABdhPJxb7icFxfWH/GZOXulDFhi/cWtfATQReFSLmTJ3bbfzdxGr0+61zoopkwjRIIneAiOE44TjFg== X-Received: by 2002:a05:6402:1447:: with SMTP id d7mr20695849edx.367.1590499987728; Tue, 26 May 2020 06:33:07 -0700 (PDT) Received: from x1w.redhat.com (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id n25sm1623084edo.56.2020.05.26.06.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 06:33:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/14] hw/mips/malta: Add some logging for bad register offset cases Date: Tue, 26 May 2020 15:32:45 +0200 Message-Id: <20200526133247.13066-13-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200526133247.13066-1-f4bug@amsat.org> References: <20200526133247.13066-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-x532.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Aleksandar Rikalo , libvir-list@redhat.com, Thomas Huth , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Markovic , Huacai Chen , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Aleksandar Markovic Log the cases where a guest attempts read or write using bad register offset. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Markovic Message-id: <20200518200920.17344-21-aleksandar.qemu.devel@gmail.com> [PMD: Replaced TARGET_FMT_lx by HWADDR_PRIX] Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/malta.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index e4c4de1b4e..b673a3a248 100644 --- a/hw/mips/malta.c +++ b/hw/mips/malta.c @@ -427,10 +427,9 @@ static uint64_t malta_fpga_read(void *opaque, hwaddr addr, break; default: -#if 0 - printf("malta_fpga_read: Bad register offset 0x" TARGET_FMT_lx "\n", - addr); -#endif + qemu_log_mask(LOG_GUEST_ERROR, + "malta_fpga_read: Bad register addr 0x%"HWADDR_PRIX"\n", + addr); break; } return val; @@ -515,10 +514,9 @@ static void malta_fpga_write(void *opaque, hwaddr addr, break; default: -#if 0 - printf("malta_fpga_write: Bad register offset 0x" TARGET_FMT_lx "\n", - addr); -#endif + qemu_log_mask(LOG_GUEST_ERROR, + "malta_fpga_write: Bad register addr 0x%"HWADDR_PRIX"\n", + addr); break; } } -- 2.21.3