From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 04/10] tests/migration: Tighten error checking
Date: Wed, 27 May 2020 07:59:39 +0200 [thread overview]
Message-ID: <20200527055945.6774-5-armbru@redhat.com> (raw)
In-Reply-To: <20200527055945.6774-1-armbru@redhat.com>
migrate_get_socket_address() neglects to check
visit_type_SocketAddressList() failure. This smells like a leak, but
it actually will crash dereferencing @addrs. Pass &error_abort to
remove the code smell.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505101908.6207-5-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/qtest/migration-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2568c9529c..dc3490c9fa 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -13,6 +13,7 @@
#include "qemu/osdep.h"
#include "libqtest.h"
+#include "qapi/error.h"
#include "qapi/qmp/qdict.h"
#include "qemu/module.h"
#include "qemu/option.h"
@@ -301,7 +302,6 @@ static char *migrate_get_socket_address(QTestState *who, const char *parameter)
{
QDict *rsp;
char *result;
- Error *local_err = NULL;
SocketAddressList *addrs;
Visitor *iv = NULL;
QObject *object;
@@ -310,7 +310,7 @@ static char *migrate_get_socket_address(QTestState *who, const char *parameter)
object = qdict_get(rsp, parameter);
iv = qobject_input_visitor_new(object);
- visit_type_SocketAddressList(iv, NULL, &addrs, &local_err);
+ visit_type_SocketAddressList(iv, NULL, &addrs, &error_abort);
visit_free(iv);
/* we are only using a single address */
--
2.21.3
next prev parent reply other threads:[~2020-05-27 6:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 5:59 [PULL 00/10] Error reporting patches for 2020-05-27 Markus Armbruster
2020-05-27 5:59 ` [PULL 01/10] nvdimm: Plug memory leak in uuid property setter Markus Armbruster
2020-05-27 5:59 ` [PULL 02/10] xen: Fix and improve handling of device_add usb-host errors Markus Armbruster
2020-05-27 5:59 ` [PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct() Markus Armbruster
2020-05-27 5:59 ` Markus Armbruster [this message]
2020-05-27 5:59 ` [PULL 05/10] error: Use error_reportf_err() where appropriate Markus Armbruster
2020-05-27 5:59 ` [PULL 06/10] mips/malta: Fix create_cps() error handling Markus Armbruster
2020-05-27 5:59 ` [PULL 07/10] mips/boston: Fix boston_mach_init() " Markus Armbruster
2020-05-27 5:59 ` [PULL 08/10] mips/boston: Plug memory leak in boston_mach_init() Markus Armbruster
2020-05-27 5:59 ` [PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init() Markus Armbruster
2020-05-27 5:59 ` [PULL 10/10] i386: Fix x86_cpu_load_model() error API violation Markus Armbruster
2020-05-28 11:08 ` [PULL 00/10] Error reporting patches for 2020-05-27 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527055945.6774-5-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).