From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paul Burton <pburton@wavecomp.com>,
Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Subject: [PULL 08/10] mips/boston: Plug memory leak in boston_mach_init()
Date: Wed, 27 May 2020 07:59:43 +0200 [thread overview]
Message-ID: <20200527055945.6774-9-armbru@redhat.com> (raw)
In-Reply-To: <20200527055945.6774-1-armbru@redhat.com>
Fixes: df1d8a1f29f567567b9d20be685a4241282e7005
Cc: Paul Burton <pburton@wavecomp.com>
Cc: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200505101908.6207-9-armbru@redhat.com>
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
---
hw/mips/boston.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 2832dfa6ae..a896056be1 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -426,7 +426,6 @@ static void boston_mach_init(MachineState *machine)
{
DeviceState *dev;
BostonState *s;
- Error *err = NULL;
MemoryRegion *flash, *ddr_low_alias, *lcd, *platreg;
MemoryRegion *sys_mem = get_system_memory();
XilinxPCIEHost *pcie2;
@@ -467,7 +466,8 @@ static void boston_mach_init(MachineState *machine)
sysbus_mmio_map_overlap(SYS_BUS_DEVICE(&s->cps), 0, 0, 1);
flash = g_new(MemoryRegion, 1);
- memory_region_init_rom(flash, NULL, "boston.flash", 128 * MiB, &err);
+ memory_region_init_rom(flash, NULL, "boston.flash", 128 * MiB,
+ &error_fatal);
memory_region_add_subregion_overlap(sys_mem, 0x18000000, flash, 0);
memory_region_add_subregion_overlap(sys_mem, 0x80000000, machine->ram, 0);
--
2.21.3
next prev parent reply other threads:[~2020-05-27 6:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 5:59 [PULL 00/10] Error reporting patches for 2020-05-27 Markus Armbruster
2020-05-27 5:59 ` [PULL 01/10] nvdimm: Plug memory leak in uuid property setter Markus Armbruster
2020-05-27 5:59 ` [PULL 02/10] xen: Fix and improve handling of device_add usb-host errors Markus Armbruster
2020-05-27 5:59 ` [PULL 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct() Markus Armbruster
2020-05-27 5:59 ` [PULL 04/10] tests/migration: Tighten error checking Markus Armbruster
2020-05-27 5:59 ` [PULL 05/10] error: Use error_reportf_err() where appropriate Markus Armbruster
2020-05-27 5:59 ` [PULL 06/10] mips/malta: Fix create_cps() error handling Markus Armbruster
2020-05-27 5:59 ` [PULL 07/10] mips/boston: Fix boston_mach_init() " Markus Armbruster
2020-05-27 5:59 ` Markus Armbruster [this message]
2020-05-27 5:59 ` [PULL 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init() Markus Armbruster
2020-05-27 5:59 ` [PULL 10/10] i386: Fix x86_cpu_load_model() error API violation Markus Armbruster
2020-05-28 11:08 ` [PULL 00/10] Error reporting patches for 2020-05-27 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527055945.6774-9-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=pburton@wavecomp.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).