From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, cohuck@redhat.com,
thuth@redhat.com, david@redhat.com
Subject: [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1
Date: Wed, 27 May 2020 03:49:11 -0400 [thread overview]
Message-ID: <20200527074920.43669-1-frankja@linux.ibm.com> (raw)
The bios is in dire need for a cleanup as there are still a lot of
magic constants being used throughout as well as duplicated code.
In the first part of this series we consolidate constants and
functions, as well as doing some minor cleanups and fixes.
The patches are available here:
https://github.com/frankjaa/qemu/pull/new/cleanup_bios
v3:
* Dropped 0x00 to 0x0/0 patch
* Moved some timing functions into helper.h instead of time.h
* Fixed IPL psw manipulation in dasd-ipl.c
* Minor cosmetic fixes found by review
v2:
* Included cio fixup to get rid of compile errors...
* Minor cosmetic fixes found by review
Janosch Frank (9):
pc-bios: s390x: cio.c cleanup and compile fix
pc-bios: s390x: Consolidate timing functions into time.h
pc-bios: s390x: Move sleep and yield to helper.h
pc-bios: s390x: Get rid of magic offsets into the lowcore
pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant
pc-bios: s390x: Use PSW masks where possible and introduce
PSW_MASK_SHORT_ADDR
pc-bios: s390x: Move panic() into header and add infinite loop
pc-bios: s390x: Use ebcdic2ascii table
pc-bios: s390x: Make u32 ptr check explicit
pc-bios/s390-ccw/bootmap.c | 4 +---
pc-bios/s390-ccw/cio.c | 40 +++++++++++++++++++---------------
pc-bios/s390-ccw/cio.h | 17 ++++++++++-----
pc-bios/s390-ccw/dasd-ipl.c | 5 ++---
pc-bios/s390-ccw/helper.h | 19 +++++++++++++++-
pc-bios/s390-ccw/jump2ipl.c | 10 ++++-----
pc-bios/s390-ccw/main.c | 15 +++----------
pc-bios/s390-ccw/menu.c | 1 +
pc-bios/s390-ccw/netmain.c | 23 +++----------------
pc-bios/s390-ccw/s390-arch.h | 4 +++-
pc-bios/s390-ccw/s390-ccw.h | 27 ++++++-----------------
pc-bios/s390-ccw/start.S | 5 +++--
pc-bios/s390-ccw/time.h | 23 +++++++++++++++++++
pc-bios/s390-ccw/virtio-net.c | 2 ++
pc-bios/s390-ccw/virtio-scsi.c | 2 ++
pc-bios/s390-ccw/virtio.c | 18 +++------------
16 files changed, 108 insertions(+), 107 deletions(-)
create mode 100644 pc-bios/s390-ccw/time.h
--
2.25.1
next reply other threads:[~2020-05-27 7:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:49 Janosch Frank [this message]
2020-05-27 7:49 ` [PATCH v3 1/9] pc-bios: s390x: cio.c cleanup and compile fix Janosch Frank
2020-05-27 8:24 ` Christian Borntraeger
2020-05-27 8:34 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 2/9] pc-bios: s390x: Consolidate timing functions into time.h Janosch Frank
2020-05-27 8:36 ` Christian Borntraeger
2020-05-27 8:41 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 3/9] pc-bios: s390x: Move sleep and yield to helper.h Janosch Frank
2020-05-27 8:34 ` Christian Borntraeger
2020-05-27 8:35 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 4/9] pc-bios: s390x: Get rid of magic offsets into the lowcore Janosch Frank
2020-05-27 8:50 ` Christian Borntraeger
2020-05-27 11:23 ` Janosch Frank
2020-05-27 7:49 ` [PATCH v3 5/9] pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant Janosch Frank
2020-05-27 7:49 ` [PATCH v3 6/9] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Janosch Frank
2020-05-27 7:49 ` [PATCH v3 7/9] pc-bios: s390x: Move panic() into header and add infinite loop Janosch Frank
2020-05-27 7:49 ` [PATCH v3 8/9] pc-bios: s390x: Use ebcdic2ascii table Janosch Frank
2020-05-27 7:49 ` [PATCH v3 9/9] pc-bios: s390x: Make u32 ptr check explicit Janosch Frank
2020-05-27 10:30 ` [PATCH v3 0/9] pc-bios: s390x: Cleanup part 1 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527074920.43669-1-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).