From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Alexey Krasikov <alex-krasikov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v4 1/3] crypto/secret: move main logic from 'secret' to 'secret_common'.
Date: Wed, 27 May 2020 10:44:43 +0100 [thread overview]
Message-ID: <20200527094443.GE2665520@redhat.com> (raw)
In-Reply-To: <20200525111655.4127-2-alex-krasikov@yandex-team.ru>
On Mon, May 25, 2020 at 02:16:53PM +0300, Alexey Krasikov wrote:
> Create base class 'common secret'. Move common data and logic from
> 'secret' to 'common_secret' class. This allowed adding abstraction layer
> for easier adding new 'secret' objects in future.
> Convert 'secret' class to child from basic 'secret_common' with 'data'
> and 'file' properties.
>
> Signed-off-by: Alexey Krasikov <alex-krasikov@yandex-team.ru>
> ---
> crypto/Makefile.objs | 1 +
> crypto/secret.c | 347 +---------------------------
> crypto/secret_common.c | 403 +++++++++++++++++++++++++++++++++
> include/crypto/secret.h | 20 +-
> include/crypto/secret_common.h | 68 ++++++
> 5 files changed, 482 insertions(+), 357 deletions(-)
> create mode 100644 crypto/secret_common.c
> create mode 100644 include/crypto/secret_common.h
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2020-05-27 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 11:16 [PATCH v4 0/3] Add secret_keyring object Alexey Krasikov
2020-05-25 11:16 ` [PATCH v4 1/3] crypto/secret: move main logic from 'secret' to 'secret_common' Alexey Krasikov
2020-05-27 9:44 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527094443.GE2665520@redhat.com \
--to=berrange@redhat.com \
--cc=alex-krasikov@yandex-team.ru \
--cc=qemu-devel@nongnu.org \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).