From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Cc: kbastian@mail.uni-paderborn.de
Subject: [PATCH v2 1/5] target/tricore: Don't save pc in generate_qemu_excp
Date: Fri, 29 May 2020 09:21:44 +0200 [thread overview]
Message-ID: <20200529072148.284037-2-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <20200529072148.284037-1-kbastian@mail.uni-paderborn.de>
EXCP_DEBUG is the only user. If we encounter a jump in tricore-gdb it's
target was overwritten by generate_qemu_excp() and we would never leave.
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
target/tricore/translate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 609d75ae8a..65a33e5ad8 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -3264,7 +3264,6 @@ static void generate_trap(DisasContext *ctx, int class, int tin)
static void generate_qemu_excp(DisasContext *ctx, int excp)
{
TCGv_i32 tmp = tcg_const_i32(excp);
- gen_save_pc(ctx->base.pc_next);
gen_helper_qemu_excp(cpu_env, tmp);
ctx->base.is_jmp = DISAS_NORETURN;
tcg_temp_free(tmp);
--
2.26.2
next prev parent reply other threads:[~2020-05-29 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 7:21 [PATCH v2 0/5] TriCore fixes and gdbstub Bastian Koppelmann
2020-05-29 7:21 ` Bastian Koppelmann [this message]
2020-06-01 19:48 ` [PATCH v2 1/5] target/tricore: Don't save pc in generate_qemu_excp Richard Henderson
2020-05-29 7:21 ` [PATCH v2 2/5] target/tricore: Move translate feature check to ctx Bastian Koppelmann
2020-06-01 19:49 ` Richard Henderson
2020-05-29 7:21 ` [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep Bastian Koppelmann
2020-06-01 21:04 ` Richard Henderson
2020-05-29 7:21 ` [PATCH v2 4/5] target/tricore: Implement tricore_cpu_get_phys_page_debug Bastian Koppelmann
2020-06-01 21:17 ` Richard Henderson
2020-05-29 7:21 ` [PATCH v2 5/5] target/tricore: Implement gdbstub Bastian Koppelmann
2020-05-29 8:31 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529072148.284037-2-kbastian@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).